coq: init at 8.8+beta1 #37591
Merged
coq: init at 8.8+beta1 #37591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: coq Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: coq Partial log (click to expand)
|
|
@GrahamcOfBorg build coq_8_8 |
|
Success on x86_64-linux (full log) Attempted: coq_8_8 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: coq_8_8 Partial log (click to expand)
|
|
LGTM, but I'm not an expert on this part of the codebase. cc @jwiegley since appears he works on this often. |
|
It all looks good to me. I'd made similar changes locally last week when it was just "pre" and not yet "beta". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on darwin and debian.
Drops the
-optconfigure flag, which has been deprecated (and a no-op) since at least Coq 8.5.