lua-{5.2,5.3}: cross fixups, drop crossAttrs #37599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly just forward environment variables to make arguments, this partially reverts 5d1e51a which removed them because they're already set in env-- but that's not enough to override make vars. Also, readline is buildInput not nativeBuildInput (we need headers and to link against it)
7c6f434c
approved these changes
Mar 21, 2018
|
Of course, I have never cross-compiled Lua… |
So you're not biased like all that lua-cross crowd! 😁 |
|
@angerman I'd like to merge this, feeling guilt-free for dropping crossAttrs cruft since it didn't even eval until dtzWill@681555c . That said, since you're working on Darwin and mingw thought I'd check before possibly introducing breakage. Thoughts/objections? |
|
I’ve not touched or used lua in Nix at all. |
|
Great! I ran into it via cross-haskell when attempting to build pandoc (was first haskell package I thought of, but it's very ambitious in terms of dependencies haha). Just wanted to make sure, thanks for quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly just forward environment variables to make arguments,
this partially reverts 5d1e51a
which removed them because they're already set in env--
but that's not enough to override make vars.
Also, readline is buildInput not nativeBuildInput
(we need headers and to link against it)
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)