Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdesktop: fixed GLib-GIO-ERROR #37587

Merged
merged 1 commit into from Mar 22, 2018
Merged

tdesktop: fixed GLib-GIO-ERROR #37587

merged 1 commit into from Mar 22, 2018

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented Mar 21, 2018

Motivation for this change

Fixes telegram-desktop crash with GLib-GIO-ERROR **: No GSettings schemas are installed on the system on choose-files dialogue.
Fix taken here: #21700.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member

primeos commented Mar 22, 2018

Tested and merged it, thanks :)

@vidbina
Copy link
Contributor

vidbina commented Mar 26, 2018

@primeos and @not-fl3, sorry for necrobumping but I just want to learn why this approach is better than just adding wrapGAppsHook to the nativeBuildInputs. That is how I "solved" the problem on my own setup and it feels a bit cleaner because

  • there is less repetition since we don't end up redefining the same env vars in every individual package,
  • the wrapper can be improved (or broken 😝) and all packages that utilize it will reflect the change
  • the wrapper does a bunch of things that are probably good practice in terms of GTK app house-keeping but aren't failing yet because a situation hasn't presented itself to remind us that perhaps the setup is still lacking.

I could imagine that the approach in the PR is better in that it only provides the minimal change necessary to resolve the reported error whereas the wrapper may end up doing a lot more that isn't directly related to this problem.

Would like your 2cts on this. Just trying to learn what to do the next time I run into a similar issue 😉

vidbina added a commit to vidbina/nixos-configuration that referenced this pull request Mar 26, 2018
Just a solution until NixOS/nixpkgs#37587 gets
merged into 18.03. I've asked why the approach in the previously
mentioned PR is better because I don't fully see it yet (apart from the
fact that the PR presents the minimal change needed to solve the
problem, whereas the wrappGAppsHook approach does a lot more).
@primeos
Copy link
Member

primeos commented Mar 27, 2018

@vidbina Thanks for your comment :) The answer is actually pretty simple, I just wasn't aware of wrapGAppsHook (should probably be documented in the nixpkgs manual).

Using wrapGAppsHook for this is a better solution (but obviously the old solution worked fine as well) and might fix some other/future potential errors as well (like you've stated). I've changed it in 9a4871a. I've used it a bit differently to avoid creating two wrappers (or even three, if it wraps the existing wrapper and the binary).

@vidbina
Copy link
Contributor

vidbina commented Mar 27, 2018

@primeos kewl. Asked another noob questions about the [@] bit in gappsWrapperArgs[@] as a comment to your commit. I agree that it should be added to the docs, I also just learned about it after someone commented about it on a GitHub thread I was tracking. And even if it is documented, I don't always find the docs too intuitive to explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants