-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guile-1.8: Fix and clean up libtool
propagation fixes
#37589
Conversation
@GrahamcOfBorg build lilypond |
Failure on x86_64-darwin (full log) Attempted: lilypond Partial log (click to expand)
|
Darwin failure: |
f0e9c2d
to
d974eb4
Compare
Success on x86_64-linux (full log) Attempted: lilypond Partial log (click to expand)
|
@GrahamcOfBorg build lilypong guile_2_2 guile_2_0 guile_1_8 |
@GrahamcOfBorg build lilypond |
d974eb4
to
f5407b8
Compare
libtool
to propagatedBuildInputs
libtool
propagation fixes
OK think I got this into a state where I like it. Hopefully OfBorg agrees. @vcunat we should cherry-pick this. |
@GrahamcOfBorg build lilypond guile_2_2 guile_2_0 guile_1_8 |
Thanks @7c6f434c |
Failure on x86_64-linux (full log) Attempted: lilypond Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: guile_2_2, guile_2_0, guile_1_8 The following builds were skipped because they don't evaluate on x86_64-darwin: lilypong Partial log (click to expand)
|
Erm. One of Guile versions is a GTK dependency which gives us a large rebuild… |
Failure on x86_64-darwin (full log) Attempted: lilypond, guile_2_2, guile_2_0, guile_1_8 Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: lilypond Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: guile_2_2, guile_2_0, guile_1_8 The following builds were skipped because they don't evaluate on aarch64-linux: lilypong Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: guile_2_2, guile_2_0, guile_1_8 The following builds were skipped because they don't evaluate on x86_64-linux: lilypong Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: lilypond, guile_2_2, guile_2_0, guile_1_8 Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: lilypond Partial log (click to expand)
|
I think it got worse than the first version… |
Failure on aarch64-linux (full log) Attempted: lilypond, guile_2_2, guile_2_0, guile_1_8 Partial log (click to expand)
|
@Ericson2314 Perhaps at this point it would make more sense to merge the simple fix that works? |
@Ericson2314 I support the plan that @mdorman force-pushes whatever allows |
Agreed, may packets include asciidoctor which breaks lots of builds, making nox-review unusable. |
f5407b8
to
17a6f0e
Compare
Sorry for that; I'm fine with that too. Since nobody did then I force-pushed a fix so the glob expands properly, but feel-free to force-push again back the way it was. |
@GrahamcOfBorg build lilypond guile_2_2 guile_2_0 guile_1_8 |
@Ericson2314 and now without syntax errors, please? I would prefer a fix that wouldn't trigger an almost-stdenv rebuild to get merged to master, though (and the more comprehensive fix will go to staging, I guess) |
Success on x86_64-darwin (full log) Attempted: guile_2_2, guile_2_0 The following builds were skipped because they don't evaluate on x86_64-darwin: lilypond, guile_1_8 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: guile_2_2, guile_2_0 The following builds were skipped because they don't evaluate on aarch64-linux: lilypond, guile_1_8 Partial log (click to expand)
|
Oh I didn't see the mass rebuild either. Doing that. |
Success on x86_64-linux (full log) Attempted: guile_2_2, guile_2_0 The following builds were skipped because they don't evaluate on x86_64-linux: lilypond, guile_1_8 Partial log (click to expand)
|
17a6f0e
to
2119041
Compare
libtool
propagation fixeslibtool
propagation fixes
@GrahamcOfBorg build lilypond guile_1_8 |
Failure on x86_64-darwin (full log) Attempted: lilypond, guile_1_8 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: lilypond, guile_1_8 Partial log (click to expand)
|
Now that the circle of life is complete, I can merge what I didn't merge fast enough the first time… |
Failure on aarch64-linux (full log) Attempted: lilypond, guile_1_8 Partial log (click to expand)
|
@Ericson2314: I don't immediately see what to do about this and 18.03. Lilypond does build, and the guile expression has seen more changes since the fork than this PR. |
Oh I thought this was the one new thing post fork. No worries then. |
Motivation for this change
Fixes #37548
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)