Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 044d4b0875e6
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e58624a87734
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 21, 2018

  1. edk2: Reformat a bit for readability 

    - Have only one sed expression per line
- Put the important stuff closer to the command and not hidden in some
continuation line. That is, don't do:

sed \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <IMPORTANT STUFF>

but:

sed <IMPORTANT STUFF> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff> \
    <boring stuff>
    @dezgeg
    dezgeg committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    1d854b4 View commit details
    Browse the repository at this point in the history

  2. OVMF: Reformat a bit for readability 

    - Use 'somePkg == null' instead of 'somePkg == false' which is more
  conventional in rest of Nixpkgs
- Use lib.optionalString where applicable
    @dezgeg
    dezgeg committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    1645011 View commit details
    Browse the repository at this point in the history

  3. edk2, OVMF: Build on aarch64 

    And also build in parallel.

I don't understand why we manually tediously link every single directory
from the source, but I don't want to investigate too much.
    @dezgeg
    dezgeg committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    f59eab7 View commit details
    Browse the repository at this point in the history

  4. nixos/tests: Make simpleUefiGrub test work on AArch64 

    Needs more refactoring for the AArch64 '-enable-kvm' stuff some day...
    @dezgeg
    dezgeg committed Mar 21, 2018
    2 Configuration menu
    Copy the full SHA
    e58624a View commit details
    Browse the repository at this point in the history