Remove wrong "Based on " links #5851
Conversation
|
And btw: if osx? || windows?Shouldn't this be better changed to something like this {% if flag?(:osx) || flag?(:win32) %}? |
src/llvm/abi/x86.cr
Outdated
| @@ -1,6 +1,6 @@ | |||
| require "../abi" | |||
|
|
|||
| # Based on https://github.com/rust-lang/rust/blob/master/src/librustc_trans/trans/cabi_x86.rs | |||
| # Based on https://github.com/rust-lang/rust/blob/master/src/librustc_trans/cabi_x86.rs | |||
There was a problem hiding this comment.
Also I think you shouldn't use master, but a specific commit hash
|
No, they musn't be changed, otherwise that would break cross compilation. Links are broken because they refer to an optional older version of rust, I'm not sure we should link to current filed because it change a lot. Maybe dig to link to a tag or commit instead. |
|
Yeah, I'd probably just delete the line... |
|
How is this "wrong"? Just find the file at that point in time and link it. https://github.com/rust-lang/rust/blob/29ac04402d53d358a1f6200bea45a301ff05b2d1/src/librustc_trans/trans/cabi_x86_64.rs Or the current one. https://github.com/rust-lang/rust/blob/50d2c3abd59af8cbed7e001b5b4e2f6a9a011112/src/librustc_target/abi/call/x86_64.rs |
Also un-does crystal-lang#5851
Also un-does crystal-lang#5851
* Split general ABI specs from x86_64-specific ones, run on every platform
To confirm that the newly added file only moves things:
$ git diff -w HEAD~:spec/compiler/codegen/c_abi/c_abi_x86_64_spec.cr spec/compiler/codegen/c_abi/c_abi_spec.cr
* Implement basics of Win64 lib ABI
Also un-does #5851
https://github.com/rust-lang/rust/blob/master/src/librustc_trans/trans/cabi_x86.rs leads to a wrong 404 page