Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkspell3: add missing isocodes dep #37576

Merged
merged 1 commit into from Mar 21, 2018
Merged

gtkspell3: add missing isocodes dep #37576

merged 1 commit into from Mar 21, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 21, 2018

Otherwise (as-is) gtkspell3 tries to find isocodes
at runtime by looking in /usr.

(configure phase nicely reports this search path
for easy comparison before/after)

Fixes problems at runtime when they can't be found:
warnings and presumably functionality loss.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gtkspell3

Partial log (click to expand)

/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9/lib/libgtkspell3-3.0.dylib: fixing dylib
/nix/store/k7cq7nwn5wygd888x8n1zagylxw2n3jq-gtkspell-3.0.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtkspell3

Partial log (click to expand)

post-installation fixup
Removing /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9/share/gtk-doc
rmdir: failed to remove '/nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9
shrinking /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9/lib/libgtkspell3-3.so.0.2.0
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9/lib
patching script interpreter paths in /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9
checking for references to /build in /nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9...
/nix/store/d8rm2pw8v014mwymf983qzhfxj1rlfrq-gtkspell-3.0.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gtkspell3

Partial log (click to expand)

post-installation fixup
Removing /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9/share/gtk-doc
rmdir: failed to remove '/nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9/share': Directory not empty
shrinking RPATHs of ELF executables and libraries in /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9
shrinking /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9/lib/libgtkspell3-3.so.0.2.0
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9/lib
patching script interpreter paths in /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9
checking for references to /build in /nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9...
/nix/store/av03xapidvclz9d3zr1as6nzlmimsmnd-gtkspell-3.0.9

@dtzWill dtzWill merged commit c945978 into NixOS:master Mar 21, 2018
@dtzWill dtzWill deleted the fix/gtkspell3-isocodes branch March 21, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg