procps-ng: updated project location #37731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
reviewed
Mar 24, 2018
| owner ="procps-ng"; | ||
| repo = "procps"; | ||
| # should be tag v3.3.12, but the sha is immutable of course, which is desirable | ||
| rev = "e0784ddaed30d095bb1d9a8ad6b5a23d10a212c4"; |
There was a problem hiding this comment.
I'd still use
rev = "v${version}";
Git tags are meant not to be moved; we check the hash of the output anyway. It will also be less error-prone on updates.
There was a problem hiding this comment.
ok, will add that
|
Otherwise I like the changes. EDIT: but it will need to target the staging branch instead, due to rebuilding thousands of packages. |
|
Should I take maintainership of procps-ng, too? |
- use the real project location and not some sf.net mirror - the meta attribute shouldn't point users to a website cluttered with ads (sf.net) where they probably just follow the link to the real project location - adapted the build to the new archive
|
@typetetris: yes. The main implications are getting e-mails from hydra.nixos.org when build status changes and being a point of contact about the package. |
|
I guessed that much and am willing to do that. Should I add the commits to this pr too? |
|
Yes, let's merge that together. |
vcunat
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
with ads (sf.net) where they probably just follow the link
to the real project location
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"My box didn't have nix 2 and with some
nix-shell -p nixUnstabletried to build all derivations, whichseemed unlikely to be caused by this.
./result/bin/)I also offer to take maintainership of procps-ng, if so desired.