Fix RubyString instances to raise FrozenError exceptions when mutations are attempted in debug mode… #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns are attempted in debug mode It was working OK in normal mode but not in debug mode.
nomadium
deleted the
fix-string-tests-with-frozen-error-related-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String instances were raising FrozenError exceptions as expected since Ruby 2.5, when modifications on frozen instances are attempted but the same was not happening in debug mode (they were raising RuntimeError, the expected behavior until 2.4).
This should fix a lot of failures in ruby-2.5 branch.
/cc: #4876