Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 52.6.0 -> 52.7.0 [Security fixes] #37723

Merged
merged 2 commits into from Mar 24, 2018
Merged

thunderbird, thunderbird-bin: 52.6.0 -> 52.7.0 [Security fixes] #37723

merged 2 commits into from Mar 24, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 24, 2018

Motivation for this change
  • Security fixes
  • Other bug fixes

https://www.mozilla.org/en-US/thunderbird/52.7.0/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 24, 2018
vcunat
vcunat approved these changes Mar 24, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, and both run OK for me.

@gebner gebner merged commit d048910 into NixOS:master Mar 24, 2018
vcunat added a commit that referenced this pull request Mar 24, 2018
@vcunat
Merge #37723:thunderbird*: 52.6.0 -> 52.7.0 (security)
950de99 
(cherry picked from commit 56fb68d)
@vcunat
Copy link
Member

vcunat commented Mar 24, 2018

In 18.03 as 9c85d19 (I incremented the PR number somehow).

@vcunat vcunat self-assigned this Mar 24, 2018
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @vcunat @gebner @GrahamcOfBorg