Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.grpcio: 1.9.1 -> 1.10.0; fix build #37716

Closed
wants to merge 1 commit into from
Closed

pythonPackages.grpcio: 1.9.1 -> 1.10.0; fix build #37716

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 23, 2018 •
edited

Motivation for this change

A slight dependency bump was needed in order to fix the build again.
Furthermore the dependency constraint for protobuf has been dropped in
order to support pythonPackages.protobuf properly.

See https://hydra.nixos.org/build/70683027/log
See ticket #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.grpcio: 1.9.1 -> 1.10.0; fix build
d3fd6b7 
A slight dependency bump was needed in order to fix the build again.
Furthermore the dependency constraint for `protobuf` has been dropped in
order to support `pythonPackages.protobuf` properly.

See https://hydra.nixos.org/build/70683027/log
See ticket NixOS#36453
@Ma27 Ma27 requested a review from FRidh as a code owner March 23, 2018 22:39
@Ma27
Copy link
Member Author

Ma27 commented Mar 23, 2018

this should also be backported to release-18.03 to fix the broken Hydra job.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.grpcio python3.pkgs.grpcio

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.grpcio, python3.pkgs.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-x86_64-3.6/grpc/_cython/cygrpc.cpython-36m-x86_64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/hn8b8n19lsl9g190rnf6q72gh2fr1h6v-python2.7-grpcio-1.10.0
/nix/store/dp3xc4mlypzw2f97kbrv0pwhy1l9mngd-python3.6-grpcio-1.10.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.grpcio, python3.pkgs.grpcio

Partial log (click to expand)

running build_ext
copying python_build/lib.linux-aarch64-3.6/grpc/_cython/cygrpc.cpython-36m-aarch64-linux-gnu.so -> src/python/grpcio/grpc/_cython
Found cython-generated files...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/xxb49k28pqdzm64jz12irzhj3gv4al0y-python2.7-grpcio-1.10.0
/nix/store/276f7ww84pz2m6lnnswrlakzhy8yi7cf-python3.6-grpcio-1.10.0

@dotlambda
Copy link
Member

Fixed in c71bcb2.

@dotlambda dotlambda closed this Mar 24, 2018
@Ma27 Ma27 deleted the fix-grpcio branch March 24, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @dotlambda @GrahamcOfBorg