Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeeyes: init at 2.0.2 #37737

Merged
merged 8 commits into from Apr 10, 2018
Merged

safeeyes: init at 2.0.2 #37737

merged 8 commits into from Apr 10, 2018

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Mar 24, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
Known issues
ERROR:root:Error in loading the plugin: notification

(safeeyes:2448): Gtk-WARNING **: Could not load a pixbuf from /org/gtk/libgtk/theme/Adwaita/assets/check-symbolic.svg.
This may indicate that pixbuf loaders or the mime database could not be found.

adding "--prefix XDG_DATA_DIRS : \"${gnome3.defaultIconTheme}/share:$GSETTINGS_SCHEMAS_PATH\"" to makeWrapperArgs didnt help

@matthewbauer
Copy link
Member

Could you add yourself as a maintainer?

@srghma
Copy link
Contributor Author

srghma commented Apr 1, 2018

@mattbillenstein added, tested

@srghma
Copy link
Contributor Author

srghma commented Apr 1, 2018 •
edited

@matthewbauer can you help me fix Known issues above?

  1. ....
  2. how to make it find Adwaita theme?

@matthewbauer
Copy link
Member

matthewbauer commented Apr 10, 2018 •
edited

  1. For the plugin thing, most likely you need to override "BIN_DIRECTORY" in safeeyes (or at least make sure that those plugins are installed correctly) :

https://github.com/slgobinath/SafeEyes/blob/992b091cf768afaa8718056adccc47893ae11962/safeeyes/Utility.py#L53

  1. I think for this you need to wrap with "GDK_PIXBUF_MODULE_FILE" see

    nixpkgs/pkgs/applications/office/tryton/default.nix

    Line 19 in 6632fd2

    ''--set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE"''

Also I think there is still a merge conflict (fix by running git fetch upstream master and git rebase upstream/master then resolve merge conflicts).

@srghma
Copy link
Contributor Author

srghma commented Apr 10, 2018

@matthewbauer

  1. other plugins are working, I think its because of gir1.2-notify-0.7 https://github.com/slgobinath/SafeEyes/blob/57418866befa1aff64d91c4de365b8aad009e18c/safeeyes/plugins/notification/plugin.py#L24 , I dont have it in deps, just noticied)
  2. I'm already using it https://github.com/NixOS/nixpkgs/pull/37737/files#diff-1a7442bd61f809d72baeb21b15f0fa47R45

2018-04-10-21 35 48-screenshot

@srghma
Copy link
Contributor Author

srghma commented Apr 10, 2018

@mattbillenstein fixed notify plugin)

@matthewbauer
Copy link
Member

matthewbauer commented Apr 10, 2018 •
edited

For 2, definitely make sure the wrapper is setting valid values for GDK_PIXBUF_MODULE_FILE. You may need pull in "gdk-pixbuf" to get it. See this too:

nixpkgs/pkgs/applications/misc/pdfshuffler/default.nix

Line 29 in 0fadb81

gappsWrapperArgs+=(--prefix XDG_DATA_DIRS : "${shared-mime-info}/share")

@matthewbauer
Copy link
Member

@GrahamcOfBorg build safeeyes

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: safeeyes

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: safeeyes

Partial log (click to expand)

/build/safeeyes-2.0.2
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2/lib  /nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2/bin
patching script interpreter paths in /nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2
checking for references to /build in /nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2...
wrapping `/nix/store/5zabcl5p8qrm1kyhbkbsjx6hr31wsjlz-safeeyes-2.0.2/bin/safeeyes'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: safeeyes

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2/lib  /nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2/bin
patching script interpreter paths in /nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2
checking for references to /build in /nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2...
wrapping `/nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2/bin/safeeyes'...
/nix/store/5q8awk429xnw6rsp5y75vf782xkxl67s-safeeyes-2.0.2

@srghma
Copy link
Contributor Author

srghma commented Apr 10, 2018

@matthewbauer it doesn't show error message anymore when I click on some button with missing icon, but cant find icons either
2018-04-10-22 22 07-screenshot

@matthewbauer
Copy link
Member

I'll merge this for now because it looks good enough. I think your icon issue may be something weird with GTK on Nix. Maybe try running it in GNOME to see if that finds the right themes. See also #5053.

@matthewbauer matthewbauer merged commit 04662c1 into NixOS:master Apr 10, 2018
@srghma
Copy link
Contributor Author

srghma commented Apr 10, 2018

@matthewbauer already)
344c142#diff-1a7442bd61f809d72baeb21b15f0fa47R21

Thanks for merge)

P.S.
thats how it looks on elementary
I dunno, maybe images are right

screenshot_from_2018-04-10_22-38-13

@srghma
Copy link
Contributor Author

srghma commented Apr 10, 2018

Dont want to run gnome, whatever, tnx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srghma @matthewbauer @GrahamcOfBorg @Janik-Haag @angelinatarapko