Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: fix incorrect sha256 #37728

Merged
merged 1 commit into from Mar 24, 2018
Merged

krita: fix incorrect sha256 #37728

merged 1 commit into from Mar 24, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

SHA256 for Krita 4.0.0 seems to be incorrect.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: krita

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: krita

Partial log (click to expand)

strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2v7q3impmqzsgc5c11qsbv19gd9dbhn3-kio-5.44.0/lib
patching script interpreter paths in /nix/store/2v7q3impmqzsgc5c11qsbv19gd9dbhn3-kio-5.44.0
checking for references to /build in /nix/store/2v7q3impmqzsgc5c11qsbv19gd9dbhn3-kio-5.44.0...
postPatchMkspecs
Moving /nix/store/2v7q3impmqzsgc5c11qsbv19gd9dbhn3-kio-5.44.0/mkspecs to /nix/store/fdnjys9skjwqrx3lbg9kpkqzqanjvdaf-kio-5.44.0-dev/mkspecs
rmdir: failed to remove '/nix/store/2v7q3impmqzsgc5c11qsbv19gd9dbhn3-kio-5.44.0': Directory not empty
postPatchMkspecs
cannot build derivation '/nix/store/0qff4ky8zdl52iw4prqd53n89acq696y-krita-4.0.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/0qff4ky8zdl52iw4prqd53n89acq696y-krita-4.0.0.drv' failed

@vcunat
Copy link
Member

vcunat commented Mar 24, 2018

No idea why it's incorrect?

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: krita

Partial log (click to expand)

[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_idle_watcher.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_psd_layer_style.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_layer_properties_icons.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/layerstyles/kis_multiple_projection.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/layerstyles/kis_layer_style_filter.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/layerstyles/kis_layer_style_filter_environment.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/layerstyles/kis_layer_style_filter_projection_plane.cpp.o
[ 21%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/layerstyles/kis_layer_style_projection_plane.cpp.o
building of '/nix/store/z8whkrhs8g00wqkqm1axxbzcnig4r6lf-krita-4.0.0.drv' timed out after 3600 seconds
error: build of '/nix/store/z8whkrhs8g00wqkqm1axxbzcnig4r6lf-krita-4.0.0.drv' failed

@lukateras
Copy link
Member Author

No idea. It looks like it has changed. Here are digests that they list: https://download.kde.org/stable/krita/4.0.0/krita-4.0.0.tar.gz.mirrorlist

$ curl -LO https://download.kde.org/stable/krita/4.0.0/krita-4.0.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   334  100   334    0     0    337      0 --:--:-- --:--:-- --:--:--   337
100  226M  100  226M    0     0  16.2M      0  0:00:13  0:00:13 --:--:-- 20.0M
$ sha256sum krita-4.0.0.tar.gz 
5ff1925361c65e5a8ca6949035ef3d1291488b63f0f473dbf62bf70a525d0336  krita-4.0.0.tar.gz

I'll ask on #krita.

@vcunat
Copy link
Member

vcunat commented Mar 24, 2018

For the record, it segfaults when I start it, though that's most likely unrelated to this PR – it seems like something around Qt plugin impurities.

@vcunat vcunat mentioned this pull request Mar 24, 2018
Merged
@ryantm
Copy link
Member

ryantm commented Mar 24, 2018

I copied the old and new tar.gz archive to Google Drive: https://drive.google.com/drive/folders/1VC8wkFxs7urv5aNSpATTE_BcfTNQAQJw?usp=sharing

There are a lot of differences:
https://gist.github.com/51cfeaa7ef757a51709dced8ed473a5c

@lukateras
Copy link
Member Author

Most of the diff is i18n changes and brushes, and I don't see any outright malicious changes in the code diff (lines 1 to 490).

@Mic92 Mic92 merged commit d262415 into master Mar 24, 2018
@zimbatm zimbatm deleted the yegortimoshenko-patch-1 branch March 24, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukateras @GrahamcOfBorg @vcunat @ryantm @Mic92