Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettext: fix dep on libiconv w/musl #37718

Closed
wants to merge 1 commit into from
Closed

gettext: fix dep on libiconv w/musl #37718

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 23, 2018

AFAICT this should "always" be provided (gettext dep on libiconv)
but the conditions present are used to avoid a bootstrapping problem
on Linux/glibc since there iconv == stdenv.cc.libc.
(see issues linked in expression above modified line)

Fix this on musl by narrowing the check to glibc.

I'm not sure what the Cygwin situation is about, so leaving it alone.

Fixes musl-native build of things requiring gettext...
for example gobjectIntrospection.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
gettext: fix dep on libiconv w/musl
c3136e5 
AFAICT this should "always" be provided (gettext dep on libiconv)
but the conditions present are used to avoid a bootstrapping problem
on Linux/glibc since there `iconv == stdenv.cc.libc`.
(see issues linked in expression above modified line)

Fix this on musl by narrowing the check to glibc.

I'm not sure what the Cygwin situation is about, so leaving it alone.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gettext

Partial log (click to expand)

/nix/store/biv22ang6z5yviggwb0v2yydvsf82mgc-gettext-0.19.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gettext

Partial log (click to expand)

/nix/store/6iwz2pqaaycznylbi38vk0yk2fhyvh3s-gettext-0.19.8

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gettext

Partial log (click to expand)

chmod -R u+w /nix/store/6chhwxykx2ra3kjqc9bfn3sy4knli2yv-CF-osx-10.10.5/System/Library/Frameworks
install_name_tool -id @rpath/CoreFoundation.framework/Versions/A/CoreFoundation /nix/store/6chhwxykx2ra3kjqc9bfn3sy4knli2yv-CF-osx-10.10.5/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
Installing done.  The framework is in /nix/store/6chhwxykx2ra3kjqc9bfn3sy4knli2yv-CF-osx-10.10.5/System/Library/Frameworks
post-installation fixup
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/6chhwxykx2ra3kjqc9bfn3sy4knli2yv-CF-osx-10.10.5
cannot build derivation '/nix/store/8531jnav21xjamn3rd6210k6sr4fyn1f-stdenv-darwin.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/h7inv3dv6hjfpx3d09kgfzv0djzjn272-libiconv-osx-10.11.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/agw215vaqbqd9zkvadrf0zzsm53r1598-gettext-0.19.8.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/agw215vaqbqd9zkvadrf0zzsm53r1598-gettext-0.19.8.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Mar 24, 2018

This change might be in the right direction, but after merging with latest staging/master things aren't working as they were previously-- so I'm closing this for now while I investigate further.

@dtzWill dtzWill closed this Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg