Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpid-cpp: fix build #37717

Merged
merged 1 commit into from Mar 27, 2018
Merged

qpid-cpp: fix build #37717

merged 1 commit into from Mar 27, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 23, 2018 •
edited

Motivation for this change

The compilation broke due to the flag -Werror=int-in-bool-context
which caused several compilation errors with GCC v7. Disabling this
warning manually with -Wno-error in NIX_CFLAGS_COMPILE should be
fine.

This package experienced several radical changes as the entire python
build in $src/management/python was broken since the given Python
interpreter missed several needed modules (including
pythonPackages.qpid-python). As the CMake build tried to invoke the
affected setup.py manually and patched the shebangs with disutil and
caused non-functional executables, I split the package up into two
parts, the actual qpid-cpp lib and the Python module that will be
composed using buildEnv.

Furthermore I added myself as maintainer for the package as the diff
became quite huge and we should have more folks available to maintain
this.

See https://hydra.nixos.org/build/71519082/log
See tickets #36453 and #31747

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 changed the title qpid-cpp: fix build WIP qpid-cpp: fix build Mar 23, 2018
@Ma27
Copy link
Member Author

Ma27 commented Mar 23, 2018

unfortunately the binaries don't work well, will start investigation

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)

     http://www.boost.org/more/getting_started/unix-variants.html

   - Boost.Build documentation:
     http://www.boost.org/boost-build2/doc/html/index.html

building
Invalid value for the '-j' option, valid values are 1 through 64.
builder for '/nix/store/0ffzdwbxgmhn1pbcqlq88c976536fj8q-boost-1.55.0.drv' failed with exit code 1
cannot build derivation '/nix/store/jdn3zj6641cix0rg0igjsz4pwi1w9bfl-qpid-cpp-1.37.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/jdn3zj6641cix0rg0igjsz4pwi1w9bfl-qpid-cpp-1.37.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)

gzipping man pages under /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/lib  /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/lib64  /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/libexec  /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/bin  /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/sbin
patching script interpreter paths in /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0
/nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd-primary: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/libexec/qpid-qls-analyze: interpreter directive changed from "/usr/bin/env python" to "/nix/store/mqwnygh4nb8hdvj3sr9vr092kn39xhpm-python-2.7.14/bin/python"
checking for references to /tmp/nix-build-qpid-cpp-1.37.0.drv-0 in /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0...
moving /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/sbin/* to /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/bin
moving /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/lib64/* to /nix/store/1jg56ngd3vkrqvh4fkgq894kcw1axml3-qpid-cpp-1.37.0/lib

@Ma27 Ma27 changed the title WIP qpid-cpp: fix build qpid-cpp: fix build Mar 27, 2018
@Ma27 Ma27 mentioned this pull request Mar 27, 2018
Closed
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)


   - Boost.Build documentation:
     http://www.boost.org/boost-build2/doc/html/index.html

building
Invalid value for the '-j' option, valid values are 1 through 64.
builder for '/nix/store/0ffzdwbxgmhn1pbcqlq88c976536fj8q-boost-1.55.0.drv' failed with exit code 1
cannot build derivation '/nix/store/h3kk4bygai1fg0ndn9zvpr7mns06jn19-qpid-cpp-1.37.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hfqxqcf09khakyxpnfdnm6a6zvfd28m0-qpid-cpp-1.37.0-env.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/hfqxqcf09khakyxpnfdnm6a6zvfd28m0-qpid-cpp-1.37.0-env.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)

strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/lib64  /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/libexec  /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/bin  /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/sbin
patching script interpreter paths in /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0
/nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd-primary: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0...
moving /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/sbin/* to /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/bin
moving /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/lib64/* to /nix/store/z4y9m583vqx97lkrzndszs1sb7v6nk2s-qpid-cpp-1.37.0/lib
building '/nix/store/c3j6yllwmsbj1xssvfvvfd881z4siclf-qpid-cpp-1.37.0-env.drv'...
created 56 symlinks in user environment

@Ma27
qpid-cpp: fix build
50dbfb7 
The compilation broke due to the flag `-Werror=int-in-bool-context`
which caused several compilation errors with GCC v7. Disabling this
warning manually with `-Wno-error` in `NIX_CFLAGS_COMPILE` should be
fine.

This package experienced several radical changes as the entire python
build in `$src/management/python` was broken since the given Python
interpreter missed several needed modules (including
`pythonPackages.qpid-python`). As the CMake build tried to invoke the
affected `setup.py` manually and patched the shebangs with `disutil` and
caused non-functional executables, I split the package up into two
parts, the actual `qpid-cpp` lib and the Python module that will be
composed using `buildEnv`.

Furthermore I added myself as maintainer for the package as the diff
became quite huge and we should have more folks available to maintain
this.

See https://hydra.nixos.org/build/71519082/log
See tickets NixOS#36453 and NixOS#31747
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)


   - Boost.Build documentation:
     http://www.boost.org/boost-build2/doc/html/index.html

building
Invalid value for the '-j' option, valid values are 1 through 64.
builder for '/nix/store/0ffzdwbxgmhn1pbcqlq88c976536fj8q-boost-1.55.0.drv' failed with exit code 1
cannot build derivation '/nix/store/srlz3rg7s2h28v87p5gay9d29ddyamdp-qpid-cpp-1.37.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6dkrly96kin3jm1qcrn1jzfv4287z79x-qpid-cpp-1.37.0-env.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6dkrly96kin3jm1qcrn1jzfv4287z79x-qpid-cpp-1.37.0-env.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)

strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/lib64  /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/libexec  /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/bin  /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/sbin
patching script interpreter paths in /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0
/nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/etc/rc.d/init.d/qpidd-primary: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0...
moving /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/sbin/* to /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/bin
moving /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/lib64/* to /nix/store/iwzhr6w4ab5ppyww6nzwaq9x4kdrmf5p-qpid-cpp-1.37.0/lib
building '/nix/store/ang05hdplgp0qhmkqacbllkb84mdyh7k-qpid-cpp-1.37.0-env.drv'...
created 56 symlinks in user environment

@garbas
Copy link
Member

garbas commented Mar 27, 2018

aarch64-linux fails because of boost failure

@garbas garbas merged commit b71ffc1 into NixOS:master Mar 27, 2018
@Ma27 Ma27 deleted the fix-qpid-cpp branch March 27, 2018 17:26
@Ma27
Copy link
Member Author

Ma27 commented Mar 27, 2018

@garbas could you backport this to release-18.03, please? This is also broken on 18.03: https://hydra.nixos.org/build/71818713

@garbas garbas mentioned this pull request Mar 27, 2018
Merged
@garbas
Copy link
Member

garbas commented Mar 27, 2018

@Ma27 yup i did it in #37924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @garbas