Remove unthrown error from function argument set example #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm the code block prior to it shows a separate definition of Do you have ideas on how to clear that up? |
|
Use a different name for the second variant? |
It's not immediately obvious which previous `mul` definition applies, and is a copy-paste hazard. Staring the block with a `mul = ...` is also consistent with the other code blocks. Fixes NixOS#46
|
Ok I just redefined |
Ericson2314
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is an issue in the documentation or an irregularity in nix/nix-repl I'm running, but I'm not seeing the error that this example describes:
According to the example, this should throw an error because
cis an unused key.Running under Nix
1.11.15on macOS.