zn_poly: init at 0.9 #38805
zn_poly: init at 0.9 #38805
Conversation
| # Tuning (either autotuning or with hand-written paramters) is possible | ||
| # but not implemented here. | ||
| # It seems buggy anyways (see homepage). | ||
| buildFlags = "all libzn_poly.so"; |
There was a problem hiding this comment.
The libzn_poly.so doesn't seem very portable (for instance macOS uses .dylib, Windows uses .dll). Are you sure it's needed?
There was a problem hiding this comment.
Yes its needed, its not included in all.
I just checked and gentoo and the sage package both special-case darwin with libzn_poly.dylib. Neither has a special case for windows, although sage supports windows as far as I know.
I'll add the darwin special case, but I cannot test it.
There was a problem hiding this comment.
Okay here is the portable way to do this I think: (see
)buildFlags = "all libzn_poly${stdenv.hostPlatform.extensions.sharedLibrary}";
There was a problem hiding this comment.
Great! I changed that.
It should be targetPlatform though, right?
| installPhase = '' | ||
| mkdir -p "$out/include/zn_poly" | ||
| mkdir -p "$out/lib" | ||
| ls |
There was a problem hiding this comment.
This should be removed.
Also check to make sure "make install" doesn't work- it's okay to supply installPhase just usually a lot harder to maintain.
There was a problem hiding this comment.
Yes, its necessary. For some reason the regular make install does not install some header files and the so file. I've added a comment explaining this (and removed the stray ls).
|
Is there a package that needs "zn_poly"? It's probably okay to have in Nixpkgs but note that it's unmaintained. |
|
Its a dependency of |
|
Since github apparently doesn't allow me to mark a change request as resolved: It should be resolved. The target is still there, but more portable. |
Motivation for this change
Package zn_poly.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)