Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragonfly-reverb: init at 0.9.1 #38806

Merged
merged 1 commit into from Apr 24, 2018
Merged

dragonfly-reverb: init at 0.9.1 #38806

merged 1 commit into from Apr 24, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 11, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build dragonfly-reverb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dragonfly-reverb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

Switched to a new branch 'fetchgit'
Deleted remote-tracking branch origin/master (was bfd41a9).
Deleted remote-tracking branch origin/simplify-parameters (was 55a51f1).
Deleted remote-tracking branch origin/spectrogram (was d021e57).
Deleted remote-tracking branch origin/gh-pages (was c159351).
Deleted remote-tracking branch origin/master (was 495cb5f).
Deleted remote-tracking branch origin/vst-key-events (was 0393d1e).
fixed-output derivation produced path '/nix/store/8zcmnqaf86z4rhggwf86hnkqyakjxagm-dragonfly-reverb' with sha256 hash '1dn54xs2zllrpfjd2870g8z8pzyhn9w7rmqvrr50zy9zqzlirvv1' instead of the expected hash '1hji62sdf87sz38qgk7m6r42ak2a6s59q387qiakhnnykh3bp7vg'
cannot build derivation '/nix/store/p7zbqd158sb6z68k01mw3vbqx7a1j3ra-dragonfly-reverb-0.9.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/p7zbqd158sb6z68k01mw3vbqx7a1j3ra-dragonfly-reverb-0.9.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

Switched to a new branch 'fetchgit'
Deleted remote-tracking branch origin/gh-pages (was c159351).
Deleted remote-tracking branch origin/master (was 495cb5f).
Deleted remote-tracking branch origin/vst-key-events (was 0393d1e).
Deleted remote-tracking branch origin/master (was bfd41a9).
Deleted remote-tracking branch origin/simplify-parameters (was 55a51f1).
Deleted remote-tracking branch origin/spectrogram (was d021e57).
fixed-output derivation produced path '/nix/store/8zcmnqaf86z4rhggwf86hnkqyakjxagm-dragonfly-reverb' with sha256 hash '1dn54xs2zllrpfjd2870g8z8pzyhn9w7rmqvrr50zy9zqzlirvv1' instead of the expected hash '1hji62sdf87sz38qgk7m6r42ak2a6s59q387qiakhnnykh3bp7vg'
cannot build derivation '/nix/store/6xmh5pg9v121nsn78ghz8qnx4djp2vqw-dragonfly-reverb-0.9.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6xmh5pg9v121nsn78ghz8qnx4djp2vqw-dragonfly-reverb-0.9.0.drv' failed

Mic92
Mic92 reviewed Apr 21, 2018
View reviewed changes
pkgs/applications/audio/dragonfly-reverb/default.nix Outdated
src = fetchgit {
url = "https://github.com/michaelwillis/dragonfly-reverb";
rev = "0.9.0";
deepClone = true;
Copy link
Member

@Mic92 Mic92 Apr 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is evil and will keep breaking the hash as it already did for me:

Initialized empty Git repository in /nix/store/jawvawgdp3v30l3i640z1lnbiqp47421-dragonfly-reverb/dpf/.git/
remote: Counting objects: 7135, done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 7135 (delta 4), reused 1 (delta 0), pack-reused 7123
Receiving objects: 100% (7135/7135), 12.13 MiB | 1.50 MiB/s, done.
Resolving deltas: 100% (6046/6046), done.
From https://github.com/DISTRHO/DPF
 * [new branch]      gh-pages       -> origin/gh-pages
 * [new branch]      master         -> origin/master
 * [new branch]      vst-key-events -> origin/vst-key-events
Switched to a new branch 'fetchgit'
Deleted remote-tracking branch origin/master (was bfd41a9).
Deleted remote-tracking branch origin/simplify-parameters (was 55a51f1).
Deleted remote-tracking branch origin/spectrogram (was d021e57).
Deleted remote-tracking branch origin/gh-pages (was c159351).
Deleted remote-tracking branch origin/master (was a50ea21).
Deleted remote-tracking branch origin/vst-key-events (was 0393d1e).
fixed-output derivation produced path '/nix/store/8zcmnqaf86z4rhggwf86hnkqyakjxagm-dragonfly-reverb' with sha256 hash '1dn54xs2zllrpfjd2870g8z8pzyhn9w7rmqvrr50zy9zqzlirvv1' instead of the expected hash '1hji62sdf87sz38qgk7m6r42ak2a6s59q387qiakhnnykh3bp7vg'
cannot build derivation '/nix/store/wjygxhias169ghj4gjdn56fnbczx7f3y-dragonfly-reverb-0.9.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wjygxhias169ghj4gjdn56fnbczx7f3y-dragonfly-reverb-0.9.0.drv' failed
The invocation of 'nix-shell --no-out-link --keep-going --max-jobs 4 --option build-use-sandbox true --run true -p dragonfly-reverb' failed

Is it possible to workaround the dependency on .git?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build the packages without this option.

@magnetophon
Copy link
Member Author

@Mic92 Ah, yes, it builds for me too.
I thought deepClone was needed to get submodules; sorry for the misunderstanding.

I upgraded to 0.9.1 while I was at it.

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2018

@GrahamcOfBorg build dragonfly-reverb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dragonfly-reverb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

Writing DragonflyReverb_ui.ttl... done!
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1
shrinking /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_dsp.so
shrinking /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1/lib/lv2/DragonflyReverb.lv2/DragonflyReverb_ui.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1/lib
patching script interpreter paths in /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1
checking for references to /build in /nix/store/xrcsmrvc26hcggdgdjj76r54hzcf0max-dragonfly-reverb-0.9.1...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: dragonfly-reverb

Partial log (click to expand)

make -C freeverb3
make[1]: Entering directory '/build/dragonfly-reverb/freeverb3'
gcc libsamplerate2/samplerate.c -Wall -Wextra -pipe -MD -MP -fPIC -DPIC -DNDEBUG -O2 -mtune=generic -msse -msse2 -fdata-sections -ffunction-sections -fvisibility=hidden -std=c99  -I. -DLIBSRATE2_FLOAT -c -o samplerate.c.o
gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?
gcc: error: unrecognized command line option '-msse2'
make[1]: *** [Makefile:27: samplerate.c.o] Error 1
make[1]: Leaving directory '/build/dragonfly-reverb/freeverb3'
make: *** [Makefile:14: libs] Error 2
builder for '/nix/store/l240nf1330286zhcr1k0v88nwdx8z68z-dragonfly-reverb-0.9.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/l240nf1330286zhcr1k0v88nwdx8z68z-dragonfly-reverb-0.9.1.drv' failed

@magnetophon magnetophon changed the title dragonfly-reverb: init at 0.9.0 dragonfly-reverb: init at 0.9.1 Apr 24, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 24, 2018 •
edited

Should be disabled on aarch64. It makes assumption about x86.

@magnetophon
Copy link
Member Author

@Mic92 like this?

@Mic92 Mic92 merged commit b959c6e into NixOS:master Apr 24, 2018
@magnetophon magnetophon deleted the dragonfly-reverb branch April 24, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @matthewbauer @GrahamcOfBorg @Mic92