Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpy2: unbreak build #38814

Merged
merged 1 commit into from Apr 14, 2018
Merged

rpy2: unbreak build #38814

merged 1 commit into from Apr 14, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Tests still fail (see commend above doCheck), but the interface seems to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner April 11, 2018 22:44
Mic92
Mic92 reviewed Apr 11, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -12491,25 +12490,39 @@ in {
rpmfluff = callPackage ../development/python-modules/rpmfluff {};

rpy2 = buildPythonPackage rec {
Copy link
Member

@Mic92 Mic92 Apr 11, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move it to an external file in pkgs/development/python-modules and reference it here with callPackage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Whats the policy about that anyways?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing should be in python-packages.nix. Packages are slowly moved out of it.

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2018

@GrahamcOfBorg build python3Packages.rpy2 python2Packages.rpy2

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.rpy2, python2Packages.rpy2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.rpy2, python2Packages.rpy2

Partial log (click to expand)

shrinking /nix/store/mxh9iaigd3m70md71vg2yl6zl73s7vqh-python3.6-rpy2-2.8.2/lib/python3.6/site-packages/rpy2/rinterface/_rinterface.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/1ycq1zbd41yim0gaif3886542inmh4zb-python2.7-rpy2-2.8.2/lib/python2.7/site-packages/rpy2/rinterface/_rinterface.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1ycq1zbd41yim0gaif3886542inmh4zb-python2.7-rpy2-2.8.2/lib 
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mxh9iaigd3m70md71vg2yl6zl73s7vqh-python3.6-rpy2-2.8.2/lib 
patching script interpreter paths in /nix/store/1ycq1zbd41yim0gaif3886542inmh4zb-python2.7-rpy2-2.8.2
patching script interpreter paths in /nix/store/mxh9iaigd3m70md71vg2yl6zl73s7vqh-python3.6-rpy2-2.8.2
checking for references to /build in /nix/store/1ycq1zbd41yim0gaif3886542inmh4zb-python2.7-rpy2-2.8.2...
checking for references to /build in /nix/store/mxh9iaigd3m70md71vg2yl6zl73s7vqh-python3.6-rpy2-2.8.2...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python3Packages.rpy2, python2Packages.rpy2

Partial log (click to expand)

clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
error: command 'clang' failed with exit status 1
builder for '/nix/store/qvi4mqrhd24rg959ap22nhzi39a4hghk-python2.7-rpy2-2.8.2.drv' failed with exit code 1
16 warnings generated.
clang -bundle -undefined dynamic_lookup build/temp.macosx-10.6-x86_64-3.6/./rpy/rinterface/_rinterface.o -L/nix/store/zl3vsrqfwx4xvxagdrdqav73yl53cxps-libc++-5.0.1/lib -L/nix/store/30ybba9ahl77j4yah49c210g9bnhcpgp-R-3.4.4/lib/R/lib -L/nix/store/sm6n6vgc3gy064nnvc49b5g8a6n2cn8h-python3-3.6.5/lib -Lbuild/temp.macosx-10.6-x86_64-3.6 -L/nix/store/zl3vsrqfwx4xvxagdrdqav73yl53cxps-libc++-5.0.1/lib -L/nix/store/30ybba9ahl77j4yah49c210g9bnhcpgp-R-3.4.4/lib/R/lib -lR -lpcre -llzma -lbz2 -lz -lm -liconv -licuuc -licui18n -lr_utils -o build/lib.macosx-10.6-x86_64-3.6/rpy2/rinterface/_rinterface.cpython-36m-darwin.so
ld: library not found for -liconv
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
error: command 'clang' failed with exit status 1
builder for '/nix/store/jwfs8z63fdhy29xks6myqf40yclg5s78-python3.6-rpy2-2.8.2.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/jwfs8z63fdhy29xks6myqf40yclg5s78-python3.6-rpy2-2.8.2.drv', '/nix/store/qvi4mqrhd24rg959ap22nhzi39a4hghk-python2.7-rpy2-2.8.2.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2018

Can you disable darwin for now?

@timokau
Copy link
Member Author

timokau commented Apr 13, 2018

Done

@Mic92 Mic92 merged commit d459778 into NixOS:master Apr 14, 2018
@timokau timokau deleted the rpy2-unbreak branch April 15, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @Mic92 @GrahamcOfBorg @dotlambda