Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.macpack: init at 1.0.3 #38807

Closed
wants to merge 1 commit into from
Closed

pythonPackages.macpack: init at 1.0.3 #38807

wants to merge 1 commit into from
+21 −0

Conversation

maximedenes
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@maximedenes maximedenes requested a review from FRidh as a code owner April 11, 2018 20:17
dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/macpack/default.nix Outdated
doCheck = false;

meta = {
description = "Makes a macOS binary redistributable by searching the dependency tree and copying/patching non-system libraries.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

pkgs/development/python-modules/macpack/default.nix Outdated
meta = {
description = "Makes a macOS binary redistributable by searching the dependency tree and copying/patching non-system libraries.";
license = stdenv.lib.licenses.mit;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homepage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

pkgs/development/python-modules/macpack/default.nix Outdated
sha256 = "0xa1ybrkjkbymjw0wrk9x2w03jck5z3330f5ns1g29hlv5yr7h83";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was put there by mistake.

@maximedenes
pythonPackages.macpack: init at 1.0.3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
maximedenes Maxime Dénès
GPG key ID: FD3733DF9705E69E
Expired
Verified
Learn about vigilant mode
edc64d6
@dotlambda
Copy link
Member

@maximedenes Do you want to maintain this package?

@GrahamcOfBorg build python2.pkgs.macpack python3.pkgs.macpack

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.macpack

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.macpack

Partial log (click to expand)

writing top-level names to macpack.egg-info/top_level.txt
reading manifest file 'macpack.egg-info/SOURCES.txt'
writing manifest file 'macpack.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/wv1f0iqh0bhvdr0vajgl8l5rcbdrnhd6-python3.6-macpack-1.0.3

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Seems like there are no tests, so please redisable them after all:

# no tests implemented
doCheck = false;

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.macpack

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.macpack

Partial log (click to expand)

writing top-level names to macpack.egg-info/top_level.txt
reading manifest file 'macpack.egg-info/SOURCES.txt'
writing manifest file 'macpack.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x3b8vjcyhr3algksmh4is8p5jqpzmpm7-python3.6-macpack-1.0.3

@maximedenes
Copy link
Contributor Author

This script doesn't seem to fully support a Nix-based setup, please wait before merging, I'll investigate more.

@dotlambda
Copy link
Member

It seems to me that this isn't a library, i.e. it shouldn't be imported using import macpack. Therfore, it should use buildPythonApplication and be moved out of pythonPackages.

@dotlambda dotlambda added the 2.status: work-in-progress This PR isn't done label Apr 14, 2018
@maximedenes
Copy link
Contributor Author

It seems to me that this isn't a library, i.e. it shouldn't be imported using import macpack. Therfore, it should use buildPythonApplication and be moved out of pythonPackages.

Yes, that's a good point. Anyway, I realized that the way this utility distinguishes system libraries from user-installed ones seems fundamentally incompatible with a Nix-based layout. So I'm going to close this PR. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maximedenes @dotlambda @GrahamcOfBorg