maxima: add various fixes, re-add ecl support #38812
Conversation
| # Failures in the regression test suite won't abort the build process. We run | ||
| # the suite only so that potential errors show up in the build log. See also: | ||
| # http://sourceforge.net/tracker/?func=detail&aid=3365831&group_id=4933&atid=104933. | ||
| doCheck = true; | ||
| doCheck = ecl == null; # one tests in rtest8 fails with ecl |
There was a problem hiding this comment.
Do you think disabling a single test is a bad idea? Comments can fall out of sync easier than code…
There was a problem hiding this comment.
I tried to find the number of the failing test but for some reason couldn't reproduce the failure at all, so now I just enable tests unconditionally.
|
cc @peti |
| @@ -11,15 +11,17 @@ let | |||
| (stdenv.lib.filter (x: x != null) [ sbcl ecl rlwrap tk gnuplot ]); | |||
| in | |||
| stdenv.mkDerivation ({ | |||
| inherit version; | |||
There was a problem hiding this comment.
I'm not sure what that version attribute is for. Nix doesn't use it, and the derivation doesn't reference it either, so this seems superfluous.
There was a problem hiding this comment.
I use it in another package to locate the fas file:
MAXIMA_FAS="${maxima-ecl}/lib/maxima/${maxima-ecl.version}/binary-ecl/maxima.fas";
Also I think its a nice de-facto standard to seperate version and name metadata, even if nix doesn't use it.
There was a problem hiding this comment.
Nix does have a builtin derivation name parser that allows to separate version from the name, and some people think that using it provide better guarantees of consistency with command-line profile management tools.
I would actually prefer having a separate notion of version, but right now there is definitely no consensus in favour of it.
There was a problem hiding this comment.
Is there any disadvantage to having the version field exposed? In my opinion its cleaner than first putting it together in the name field and then parsing it again, but even if it isn't cleaner there is no harm right?
There was a problem hiding this comment.
Isn't maxima/${maxima-ecl.version} the same thing as ${maxima-ecl.name}? I don't see why that construct requires a separate version attribute.
There was a problem hiding this comment.
Ah, crap, now I see it. Sorry, I wasn't thinking straight there for a second.
There was a problem hiding this comment.
Not precisely the same: / vs -
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)