lcalc: init at 1.23 #38796
lcalc: init at 1.23 #38796
Conversation
| sha256 = "1c6dsdshgxhqppjxvxhp8yhpxaqvnz3d1mlh26r571gkq8z2bm43"; | ||
| }; | ||
|
|
||
| preConfigure = "cd src"; |
There was a problem hiding this comment.
Please use sourceRoot: https://nixos.org/nixpkgs/manual/#ssec-unpack-phase
There was a problem hiding this comment.
The patches assume to be in the lcalc-${version} directory. Using source root, it'd be necessary to
- hard code the name of that directory (it would be way nicer if the standard
unpackPhasewould rename that directory to a standardized name, likesource) - add
stripLenor however that option was called to all patches
I think its nicer the way it is.
|
@GrahamcOfBorg build lcalc |
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: lcalc Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: lcalc Partial log (click to expand)
|
| ]; | ||
|
|
||
| installFlags = [ | ||
| "DESTDIR=${placeholder "out"}" |
There was a problem hiding this comment.
Can you try using prefix here too?
There was a problem hiding this comment.
Doesn't work in this case:
installing
install flags: install SHELL=/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash PARI_DEFINE=-DINCLUDE_PARI PARI_PREFIX=/nix/store/zmmdpgflz2fqmqkkc7d92k4qv3rvfs6h-pari-2.9.4 PREFIX=/nix/store/a8ckm9idhhvb3lwnk2jgz8pwjaiisf9h-lcalc-1.23
install -d /bin
install -d /lib
install -d /include/libLfunction
install: cannot create directory '/include': Permission denied
make: *** [Makefile:273: install] Error 1
builder for '/nix/store/v3kdhl15p1sy49766gydgpf8hm6cdq8r-lcalc-1.23.drv' failed with exit code 2
There was a problem hiding this comment.
Usually this will work:
"DESTDIR=$(out)"
|
|
||
|
|
||
| -INSTALL_DIR= /usr/local | ||
| +INSTALL_DIR= $(DESTDIR) |
There was a problem hiding this comment.
You could probably get rid of this line and set $INSTALL_DIR in installFlags.
There was a problem hiding this comment.
But would that be better? It wouldnt reduce the patch size (still necessary to remove INSTALL_DIR = /usr/local) and $(DESTDIR) seems like a reasonable default.
Even without that line, DESTDIR must still be set.
There was a problem hiding this comment.
Well then just leave it like it is.
Motivation for this change
Package lcalc.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)