Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cliquer: init at 1.21 #38795

Merged
merged 1 commit into from Apr 14, 2018
Merged

cliquer: init at 1.21 #38795

merged 1 commit into from Apr 14, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package cliquer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/libraries/science/math/cliquer/default.nix Outdated
homepage = https://users.aalto.fi/~pat/cliquer.html;
description = "Routines for clique searching";
longDescription = ''
Cliquer is a set of C routines for finding cliques in an arbitrary weighted graph. It uses an exact branch-and-bound algorithm developed by Patric Östergård. It is designed with the aim of being efficient while still being flexible and easy to use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line breaks

pkgs/development/libraries/science/math/cliquer/default.nix Outdated
'';
license = with licenses; [ gpl2 ];
maintainers = with maintainers; [ timokau ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested?

pkgs/development/libraries/science/math/cliquer/default.nix
version = "1.21";
name = "cliquer-${version}";

# autotoolized version of the original cliquer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this package should have the name cliquer then. And the homepage should also be changed accordingly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its still the same package with the same functionality, just an improved / updated build. I think thats an implementation detail that would only confuse users that want to install cliquer.

However if you prefer a name change and have a different name in mind, I'm not strongly opposed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that Arch is also using autocliquer, this seems alright after all: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/cliquer#n15
However please add a downloadPage pointing to autocliquer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use

downloadPage = src.meta.homepage;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dotlambda
dotlambda reviewed Apr 14, 2018
View reviewed changes
pkgs/development/libraries/science/math/cliquer/default.nix Outdated
It is designed with the aim of being efficient while still being flexible and
easy to use.
'';
license = with licenses; [ gpl2 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get rid of the list and just use licenses.gpl2Plus:

Cliquer is licensed under the GNU General Public License as published
by the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

(from the README in the tarball)

@dotlambda
Copy link
Member

@GrahamcOfBorg build cliquer

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cliquer

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21
shrinking /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21/lib/libcliquer.so.1.0.21
shrinking /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21/bin/cl
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21/lib  /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21/bin 
patching script interpreter paths in /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21
checking for references to /build in /nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21...
/nix/store/52cr58xkzncvlgjhgrmj95772d94may6-cliquer-1.21

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cliquer

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21
shrinking /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21/bin/cl
shrinking /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21/lib/libcliquer.so.1.0.21
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21/lib  /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21/bin
patching script interpreter paths in /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21
checking for references to /build in /nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21...
/nix/store/49ipw2yk5gj5gf6n2p8lcgr9sms2cjnn-cliquer-1.21

@dotlambda dotlambda merged commit 089eefe into NixOS:master Apr 14, 2018
@timokau timokau deleted the cliquer-init branch April 15, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg