brial: init at 1.2.3 #38794

timokau · 2018-04-11T18:32:05Z

Motivation for this change

~~This depends on #38762, do not merge before that~~

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-04-12T16:53:26Z

pkgs/development/libraries/science/math/brial/default.nix

+    homepage = https://github.com/BRiAl/BRiAl;
+    description = "Legacy version of PolyBoRi maintained by sagemath developers";
+    longDescription = ''
+      M4RIE is a library for fast arithmetic with dense matrices over small finite fields of even characteristic. It uses the M4RI library, implementing the same operations over the finite field F2.


wrong longDescription

timokau · 2018-04-13T20:53:15Z

I just tried to nox-review this and it failed, don't merge.

timokau · 2018-04-13T21:15:15Z

Resolved. I had to disable the boost test framework, since thats not packaged.

dotlambda · 2018-04-14T08:17:37Z

pkgs/development/libraries/science/math/brial/default.nix

+  src = fetchFromGitHub {
+    owner = "BRiAl";
+    repo = "BRiAl";
+    rev = "${version}";


rev = version

dotlambda · 2018-04-14T08:17:44Z

pkgs/development/libraries/science/math/brial/default.nix

+    description = "Legacy version of PolyBoRi maintained by sagemath developers";
+    license = with licenses; [ gpl2 ];
+    maintainers = with maintainers; [ timokau ];
+    platforms = platforms.all;


dotlambda · 2018-04-14T08:20:07Z

pkgs/development/libraries/science/math/brial/default.nix

+  meta = with stdenv.lib; {
+    homepage = https://github.com/BRiAl/BRiAl;
+    description = "Legacy version of PolyBoRi maintained by sagemath developers";
+    license = with licenses; [ gpl2 ];


licenses.gpl2Plus: https://github.com/BRiAl/BRiAl/blob/c77c62d5ee502faaed8a16445b07fbf077bfec7c/sage-brial/brial/frontend.py#L68-L69

dotlambda · 2018-04-14T08:20:56Z

pkgs/development/libraries/science/math/brial/default.nix

+  ];
+
+  meta = with stdenv.lib; {
+    homepage = https://github.com/BRiAl/BRiAl;


inherit (src.meta) homepage

I think that is less clear than explicitly stating it. Its just more or less a coincidence that those two are the same.

dotlambda · 2018-04-14T08:36:40Z

@GrahamcOfBorg build brial

GrahamcOfBorg · 2018-04-14T08:38:30Z

Success on x86_64-linux (full log)

Attempted: brial

Partial log (click to expand)

make[1]: Leaving directory '/build/source/tests'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3
shrinking /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3/lib/libbrial.so.3.0.1
shrinking /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3/lib/libbrial_groebner.so.3.0.1
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3/lib 
patching script interpreter paths in /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3
checking for references to /build in /nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3...
/nix/store/im0yrp3msyl4bnvalfwbhlhi48zik1dm-brial-1.2.3

GrahamcOfBorg · 2018-04-14T08:46:52Z

Success on aarch64-linux (full log)

Attempted: brial

Partial log (click to expand)

make[1]: Leaving directory '/build/source/tests'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3
shrinking /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3/lib/libbrial_groebner.so.3.0.1
shrinking /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3/lib/libbrial.so.3.0.1
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3/lib
patching script interpreter paths in /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3
checking for references to /build in /nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3...
/nix/store/g86mkdsfdcn72niwy2fb6p9f0rycsnpz-brial-1.2.3

dotlambda · 2018-04-14T10:51:44Z

There are tests in https://github.com/BRiAl/BRiAl/tree/master/tests. I'm not sure whether it makes sense to run these.

dotlambda · 2018-04-14T15:52:49Z

Since this is the "legacy version of PolyBoRi maintained by sagemath developers", it should be put in the overlay.

timokau · 2018-04-15T10:11:24Z

The tagline is wrong / confusing: brial is the new one, polybori is legacy. The github short description is "Successor to PolyBoRi".

dotlambda · 2018-04-15T11:03:34Z

pkgs/development/libraries/science/math/brial/default.nix

+  ];
+
+  configureFlags = [
+    "--with-boost-unit-test-framework=no" # boost-test is not packaged


Testing would probably reduce the necessary maintenance effort. So if it isn't too difficult, I'd suggest packaging boost-test and adding doCheck = true.

I've done that (boost init commit is now included in this PR).

Thanks a lot!

timokau · 2018-04-15T12:32:14Z

Again, not ready for merge (I only tested the build non-sandboxed with boost-test before pushing, doesn't build when sandboxed).

dotlambda · 2018-04-15T12:31:04Z

pkgs/development/libraries/boost-test/default.nix

+  meta = with stdenv.lib; {
+    homepage = http://boost.org/libs/test;
+    description = "Boost.org test module";
+    license = {


There is licenses.boost.

timokau · 2018-04-15T13:06:45Z

I'm having issues with boost-test. First I thought just copying would be enough (since the boost docs indicate sometiimes it is and boost-process is packaged that way). Unfortunately its not.

The build fails here:

Scanning dependencies of target doc-example53
[ 72%] Building CXX object CMakeFiles/doc-example53.dir/tmp/nix-build-boost-test-1.66.0.drv-0/source/doc/examples/example53.run-fail.cpp.o
[ 72%] Linking CXX executable static-library-custom-init-test
/nix/store/27x7pinqdsl9f3rpbm8bsszd9fhwq266-glibc-2.27/lib/crt1.o: In function `_start':
/build/glibc-2.27/csu/../sysdeps/x86_64/start.S:104: undefined reference to `main'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/static-library-custom-init-test.dir/build.make:96: static-library-custom-init-test] Error 1
make[1]: *** [CMakeFiles/Makefile2:5806: CMakeFiles/static-library-custom-init-test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 72%] Linking CXX executable doc-example52
[ 72%] Built target doc-example52
[ 73%] Linking CXX executable doc-example51
[ 73%] Built target doc-example51
[ 74%] Linking CXX executable doc-example53
[ 74%] Built target doc-example53
make: *** [Makefile:95: all] Error 2
builder for '/nix/store/r9x5zbg7g01zlb1yzgqxksac7f9x83pg-boost-test-1.66.0.drv' failed with exit code 2

I don't know much about cmake or boost. Do you have an idea what the error might be? I pushed the update to boost-test (still not mergeable).

timokau · 2018-04-22T18:17:26Z

@peti @wkennington (maintainers of boost): Do you have an idea what causes the build failure? Do you think its a good idea to package boost-test?

timokau · 2018-05-06T13:07:19Z

Since I don't know how to proceed and apparently nobody else does either I reverted the boost-test change.

dotlambda · 2018-05-07T20:01:54Z

pkgs/development/libraries/science/math/brial/default.nix

+  };
+
+  configureFlags = [
+    "--with-boost-unit-test-framework=no"


You might want to add

# FIXME: package boost-test and enable doCheck

here and then it's good to go.

timokau · 2018-05-07T23:27:58Z

Done

dotlambda reviewed Apr 12, 2018

View reviewed changes

timokau force-pushed the brial-init branch 2 times, most recently from caa0267 to b9a1987 Compare April 13, 2018 20:46

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 13, 2018

timokau force-pushed the brial-init branch from b9a1987 to 334e341 Compare April 13, 2018 21:07

dotlambda reviewed Apr 14, 2018

View reviewed changes

timokau force-pushed the brial-init branch 2 times, most recently from 490eebf to 18a5281 Compare April 14, 2018 08:32

GrahamcOfBorg added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Apr 14, 2018

dotlambda closed this Apr 14, 2018

dotlambda reopened this Apr 14, 2018

dotlambda reviewed Apr 15, 2018

View reviewed changes

timokau force-pushed the brial-init branch from 18a5281 to 272ebd2 Compare April 15, 2018 12:26

dotlambda requested changes Apr 15, 2018

View reviewed changes

timokau changed the title ~~brial: init at 1.2.3~~ [WIP] brial: init at 1.2.3 Apr 15, 2018

timokau force-pushed the brial-init branch from 272ebd2 to d1a051c Compare April 15, 2018 13:04

matthewbauer added the 2.status: work-in-progress label Apr 21, 2018

timokau mentioned this pull request May 4, 2018

Sage on nixos #39981

Merged

8 tasks

timokau force-pushed the brial-init branch 2 times, most recently from 5eacbfa to d7ca96a Compare May 6, 2018 13:06

timokau changed the title ~~[WIP] brial: init at 1.2.3~~ brial: init at 1.2.3 May 6, 2018

dotlambda reviewed May 7, 2018

View reviewed changes

timokau force-pushed the brial-init branch from d7ca96a to 8b5ecf9 Compare May 7, 2018 23:27

brial: init at 1.2.3

8b5ecf9

dotlambda merged commit 6e6005c into NixOS:master May 8, 2018

timokau deleted the brial-init branch May 8, 2018 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

brial: init at 1.2.3 #38794

brial: init at 1.2.3 #38794

timokau commented Apr 11, 2018 •

edited

dotlambda Apr 12, 2018

timokau commented Apr 13, 2018

timokau commented Apr 13, 2018

dotlambda Apr 14, 2018

dotlambda Apr 14, 2018

dotlambda Apr 14, 2018

dotlambda Apr 14, 2018

timokau Apr 14, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

dotlambda commented Apr 14, 2018

timokau commented Apr 15, 2018

dotlambda Apr 15, 2018

timokau Apr 15, 2018

dotlambda Apr 15, 2018

timokau commented Apr 15, 2018

dotlambda Apr 15, 2018

timokau commented Apr 15, 2018

timokau commented Apr 22, 2018

timokau commented May 6, 2018

dotlambda May 7, 2018

timokau commented May 7, 2018

brial: init at 1.2.3 #38794

brial: init at 1.2.3 #38794

Conversation

timokau commented Apr 11, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

timokau commented Apr 13, 2018

timokau commented Apr 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

dotlambda commented Apr 14, 2018

timokau commented Apr 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timokau commented Apr 15, 2018

Choose a reason for hiding this comment

timokau commented Apr 15, 2018

timokau commented Apr 22, 2018

timokau commented May 6, 2018

Choose a reason for hiding this comment

timokau commented May 7, 2018

timokau commented Apr 11, 2018 •

edited