Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planarity: init at 3.0.0.5 #38800

Merged
merged 1 commit into from Apr 19, 2018
Merged

planarity: init at 3.0.0.5 #38800

merged 1 commit into from Apr 19, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package planarity.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented Apr 12, 2018

Thanks for your contribution. It builds and runs also on macOS.

dotlambda
dotlambda reviewed Apr 13, 2018
View reviewed changes
pkgs/development/libraries/science/math/planarity/default.nix Outdated
description = "A library for implementing graph algorithms";
license = with licenses; [ gpl2 ];
maintainers = with maintainers; [ timokau ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms.unix

dotlambda
dotlambda reviewed Apr 14, 2018
View reviewed changes
pkgs/development/libraries/science/math/planarity/default.nix Outdated
meta = with stdenv.lib; {
homepage = https://github.com/graph-algorithms/edge-addition-planarity-suite;
description = "A library for implementing graph algorithms";
license = with licenses; [ gpl2 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licenses.bsd3
https://github.com/graph-algorithms/edge-addition-planarity-suite/blob/master/LICENSE.TXT

@dotlambda
Copy link
Member

@GrahamcOfBorg build planarity

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: planarity

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5
shrinking /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5/bin/planarity
shrinking /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5/lib/libplanarity.so.0.0.0
gzipping man pages under /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5/lib  /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5/bin
patching script interpreter paths in /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5
checking for references to /build in /nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5...
/nix/store/rv12vsm6mrsn7hvdnzq2p4dnvdgm8ayw-planarity-3.0.0.5

@dotlambda dotlambda merged commit d8e5160 into NixOS:master Apr 19, 2018
@timokau timokau deleted the planarity-init branch April 19, 2018 13:49
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: planarity

Partial log (click to expand)

these paths will be fetched (0.08 MiB download, 0.25 MiB unpacked):
  /nix/store/k9jdwjvyfp650lmz0q3dq1v6jb46dfpi-planarity-3.0.0.5
copying path '/nix/store/k9jdwjvyfp650lmz0q3dq1v6jb46dfpi-planarity-3.0.0.5' from 'https://cache.nixos.org'...
/nix/store/k9jdwjvyfp650lmz0q3dq1v6jb46dfpi-planarity-3.0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @davidak @dotlambda @GrahamcOfBorg