Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rankwidth: init at 0.7 #38802

Merged
merged 1 commit into from Apr 23, 2018
Merged

rankwidth: init at 0.7 #38802

merged 1 commit into from Apr 23, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package rankwidth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau changed the title rankwidth: init at 0.7 [WIP] rankwidth: init at 0.7 Apr 11, 2018
@timokau timokau changed the title [WIP] rankwidth: init at 0.7 rankwidth: init at 0.7 Apr 11, 2018
dotlambda
dotlambda reviewed Apr 13, 2018
View reviewed changes
pkgs/development/libraries/science/math/rankwidth/default.nix Outdated
];

meta = with stdenv.lib; {
homepage = http://pholia.tdi.informatik.uni-frankfurt.de/~philipp/software/rw.shtml;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down

dotlambda
dotlambda reviewed Apr 13, 2018
View reviewed changes
pkgs/development/libraries/science/math/rankwidth/default.nix Outdated
description = "Calculates rank-width and rank-decompositions";
license = with licenses; [ gpl2Plus ];
maintainers = with maintainers; [ timokau ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested?

@dotlambda
Copy link
Member

Their Makefile has a check target, which currently does nothing. I think doCheck = true still makes sense in case tests are implemented in the future.

@timokau
Copy link
Member Author

timokau commented Apr 22, 2018

I agree, added.

@timokau timokau force-pushed the rankdwidth-init branch 2 times, most recently from c422548 to 0c9aaf0 Compare April 22, 2018 18:11
@dotlambda
Copy link
Member

@GrahamcOfBorg build rankwidth

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rankwidth

Partial log (click to expand)

 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 rw.h '/nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7/include'
make[1]: Leaving directory '/build/rw-0.7'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7
shrinking /nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7/lib/librw.so.0.0.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7/lib
patching script interpreter paths in /nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7
checking for references to /build in /nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7...
/nix/store/25dg8if1dl2rh2w74sx9g7327pa34a2n-rankwidth-0.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rankwidth

Partial log (click to expand)

 /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c -m 644 rw.h '/nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7/include'
make[1]: Leaving directory '/build/rw-0.7'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7
shrinking /nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7/lib/librw.so.0.0.0
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7/lib
patching script interpreter paths in /nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7
checking for references to /build in /nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7...
/nix/store/fnfmx18v30fq1izahadyggry755ag9nl-rankwidth-0.7

@dotlambda dotlambda merged commit f2ad8b2 into NixOS:master Apr 23, 2018
@timokau timokau deleted the rankdwidth-init branch April 23, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg