Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.09] chromium: build with gcc7 #38799

Merged
merged 1 commit into from Apr 11, 2018
Merged

[17.09] chromium: build with gcc7 #38799

merged 1 commit into from Apr 11, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 11, 2018

Fixes #37314

Motivation for this change

Please see the linked issue. Confirmed that CTRL-C works and I don't see other regressions in basic usage.

/cc @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c merged commit e984f9e into NixOS:release-17.09 Apr 11, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: chromium

Partial log (click to expand)

make[2]: Leaving directory '/build/adwaita-icon-theme-3.24.0'
make[1]: Leaving directory '/build/adwaita-icon-theme-3.24.0'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wgh3g1pcn2rx90i3zy98rjn2va9mp27g-adwaita-icon-theme-3.24.0
patching script interpreter paths in /nix/store/wgh3g1pcn2rx90i3zy98rjn2va9mp27g-adwaita-icon-theme-3.24.0
checking for references to /build in /nix/store/wgh3g1pcn2rx90i3zy98rjn2va9mp27g-adwaita-icon-theme-3.24.0...
cannot build derivation '/nix/store/gwq8k3na129ifqhspgay1yrzriv6xjl4-chromium-65.0.3325.162.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gwq8k3na129ifqhspgay1yrzriv6xjl4-chromium-65.0.3325.162.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: chromium

Partial log (click to expand)

checking for references to /tmp/nix-build-chromium-65.0.3325.162.drv-0 in /nix/store/7y42qxqwryn5xrh58abw91xq34jpqvhs-chromium-65.0.3325.162...
shrinking RPATHs of ELF executables and libraries in /nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox
shrinking /nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox/bin/__chromium-suid-sandbox
stripping (with flags -S) in /nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox/bin
patching script interpreter paths in /nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox
checking for references to /tmp/nix-build-chromium-65.0.3325.162.drv-0 in /nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox...
building path(s) ‘/nix/store/7nqgngq76s7rznm1g62dn955snp8wwyq-chromium-65.0.3325.162-sandbox’, ‘/nix/store/ykj4lbdzs3gnp9k8474x0dy7b96m2raw-chromium-65.0.3325.162’
'/nix/store/7nqgngq76s7rznm1g62dn955snp8wwyq-chromium-65.0.3325.162-sandbox' -> '/nix/store/6cqxjqd8hpaxkq808jbrmin2p6883h98-chromium-65.0.3325.162-sandbox'
'/nix/store/lavc9y45p60fpgnrqlcahkxc3rv3rrah-chromium-browser.desktop/share/applications/chromium-browser.desktop' -> '/nix/store/ykj4lbdzs3gnp9k8474x0dy7b96m2raw-chromium-65.0.3325.162/share/applications/chromium-browser.desktop'
/nix/store/ykj4lbdzs3gnp9k8474x0dy7b96m2raw-chromium-65.0.3325.162

@pbogdan pbogdan deleted the chromium-gcc7 branch December 3, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @7c6f434c