New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire-desktop: init at 3.0.2816 #38801
Conversation
It would also be cleaner to "compile from source" than extracting the deb file. But i think it's ok for now, so people can actually use it and that can be improved later. |
I think emoji support is quiet important for a chat app. I still cant login with username or e-mail, only phone number. And i don't see notifications. |
I'll have all that in sec. I have no idea what's up with the font's though. Edit: |
Still login problems. When i set wire to english (what is also my system language), i can activate "Check spelling when typing" in Edit menu. But i don't get any feedback when typing. I can't activate when wire lang is german. |
That has to with hunspellDicts. Are you suggesting I pull in all the dictionaries for all languages regardless of the system language? I think that's excessive for a communication app if so. |
@worldofpeace i think it's ok when only the system language is supported. But even then spell check has no function. Does it work on your system? |
@davidak Yes. I think it's an english thing :) Everything is working for me |
@davidak What's the status on this? Any other requested changes? |
I still can't log in with username or e-mail. I asked wire for details why that happens.
And can you please squash the wire commits into one? |
Ok
Good that you did that. I have multiple accounts and I've logged in and it works fine. I hope you figure that out.
Yep 😄 |
Technically you are right, but i think it's in the sense of the rule to have a more general description. People who don't know "Wire" should know for what the app is useful. In this AUR it is for example "Modern, private messenger. Based on Electron.". I like the warning about Electron :D but i think it's too technical for a normal user. You can also compare the dependencies there. |
Lol I changed my response after reading the description again. Not very descriptive. Also squash commit done. |
Can somebody please merge this? I think this meets all the requirements. |
What about "A modern, secure messenger"? It differentiate it to other programs and is less technical. I got this response from the Wire support:
Let's see if more people have any issues with this package. This state is good for now since there is a workaround. |
Really? I don't even think that's true. How do you "unofficially" support Linux and have downloads to binaries and releases just for it. I've contacted support before and they were very helpful and never said that "Linux" was a problem.
That is less technical and I'll most likely change it to that.
Does Nix in general require x amount of reviewers and testers for a package as simple as this? |
No, it just takes some time to review about >1000 PRs :D |
@matthewbauer Can this get backported into 18.03? |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)./result/bin/
)