Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire-desktop: init at 3.0.2816 #38801

Merged
merged 2 commits into from Apr 22, 2018
Merged

wire-desktop: init at 3.0.2816 #38801

merged 2 commits into from Apr 22, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented Apr 12, 2018

I'm a Wire user and had to use the browser version on NixOS, so i'm very happy about this PR.
Thanks for your contribution!

It also builds successfully on my system, but something weird is going on with the text:
untitled
(I'm using Xfce)

Also, i'm not able to login, either with e-mail or username. It works with phone number tho.

@davidak
Copy link
Member

davidak commented Apr 12, 2018

It would also be cleaner to "compile from source" than extracting the deb file. But i think it's ok for now, so people can actually use it and that can be improved later.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 12, 2018

@davidak

I'm a Wire user and had to use the browser version on NixOS, so i'm very happy about this PR.
Thanks for your contribution!

I actually couldn't believe nix didn't have this package :).

It would also be cleaner to "compile from source" than extracting the deb file. But i think it's ok for now

I think so too.

It also builds successfully on my system, but something weird is going on with the text:

Might be missing a dependency. I'm using gnome and it has a similar yet more subtle distortion.
the

There's also stuff like hunspell and emoji support that I didn't bother putting in yet. I think those should be optional.

Also, i'm not able to login, either with e-mail or username.

I can log in?

Also can you confirm for me if you see any notifications from a sent message?

@davidak
Copy link
Member

davidak commented Apr 12, 2018

I think emoji support is quiet important for a chat app.

I still cant login with username or e-mail, only phone number.

And i don't see notifications.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 12, 2018

I'll have all that in sec.

I have no idea what's up with the font's though.

Edit:
Just realized that there's a i686-linux binary as well.

@davidak
Copy link
Member

davidak commented Apr 13, 2018

Still login problems.

When i set wire to english (what is also my system language), i can activate "Check spelling when typing" in Edit menu. But i don't get any feedback when typing. I can't activate when wire lang is german.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 13, 2018

When i set wire to english (what is also my system language), i can activate "Check spelling when typing" in Edit menu. But i don't get any feedback when typing. I can't activate when wire lang is german.

That has to with hunspellDicts. Are you suggesting I pull in all the dictionaries for all languages regardless of the system language? I think that's excessive for a communication app if so.

@davidak
Copy link
Member

davidak commented Apr 13, 2018

@worldofpeace i think it's ok when only the system language is supported. But even then spell check has no function. Does it work on your system?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 13, 2018

@davidak Yes. I think it's an english thing :)

Everything is working for me

@worldofpeace
Copy link
Contributor Author

@davidak What's the status on this? Any other requested changes?

@davidak
Copy link
Member

davidak commented Apr 16, 2018

I still can't log in with username or e-mail. I asked wire for details why that happens.

description should not start with the package name.

And can you please squash the wire commits into one?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 16, 2018

description should not start with the package name.

Ok

I asked wire for details why that happens.

Good that you did that. I have multiple accounts and I've logged in and it works fine. I hope you figure that out.

And can you please squash the wire commits into one?

Yep 😄

@davidak
Copy link
Member

davidak commented Apr 16, 2018

The packages name is wire-desktop and the description starts with Wire.

Technically you are right, but i think it's in the sense of the rule to have a more general description. People who don't know "Wire" should know for what the app is useful. In this AUR it is for example "Modern, private messenger. Based on Electron.". I like the warning about Electron :D but i think it's too technical for a normal user. You can also compare the dependencies there.

@worldofpeace
Copy link
Contributor Author

Lol I changed my response after reading the description again. Not very descriptive.
How's "A cross-platform, encrypted instant messaging client"?

Also squash commit done.

@worldofpeace
Copy link
Contributor Author

Can somebody please merge this? I think this meets all the requirements.

@davidak
Copy link
Member

davidak commented Apr 19, 2018

What about "A modern, secure messenger"? It differentiate it to other programs and is less technical.

I got this response from the Wire support:

Sadly I can't be of much help. We do not support Linux officially.

Let's see if more people have any issues with this package. This state is good for now since there is a workaround.

@worldofpeace
Copy link
Contributor Author

Sadly I can't be of much help. We do not support Linux officially.

Really? I don't even think that's true. How do you "unofficially" support Linux and have downloads to binaries and releases just for it. I've contacted support before and they were very helpful and never said that "Linux" was a problem.

What about "A modern, secure messenger"? It differentiate it to other programs and is less technical.

That is less technical and I'll most likely change it to that.

Let's see if more people have any issues with this package.

Does Nix in general require x amount of reviewers and testers for a package as simple as this?

@davidak
Copy link
Member

davidak commented Apr 19, 2018

Does Nix in general require x amount of reviewers and testers for a package as simple as this?

No, it just takes some time to review about >1000 PRs :D

@matthewbauer matthewbauer merged commit c8e5811 into NixOS:master Apr 22, 2018
@worldofpeace worldofpeace deleted the wire-desktop branch April 22, 2018 06:26
@worldofpeace
Copy link
Contributor Author

@matthewbauer Can this get backported into 18.03?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants