Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 63c2d530327d
Choose a base ref
...
head repository: jruby/jruby
compare: 6c642aa11a0a
Choose a head ref
  • 2 commits
  • 45 files changed
  • 1 contributor

Commits on Apr 11, 2018

  1. Final move to push RubySymbol a bit further through to IR. This is a 

    reasonable move since RubySymbol contains both the ByteList we need for proper
display (for errors whatnot) and it also has the raw interned ID String we
use for table access of variables and identifiers.

The second reasonable reason for this move is when we execute IR we have already
bootstrapped the runtime so it is safe to have symbols here.  By pushing them
this far forward we can also just return them for instrs where we need to
return a symbol.  Like in the case of a 'def foo;end'.

This only did put instrs.  Get next.
    @enebo
    enebo committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    c7cebeb View commit details
    Browse the repository at this point in the history

  2. A lot more switching of IR to RubySymbol from ByteList. Only two weird 

    outcomes:

1. Temporary variables still use String instead of Symbol (they did not use
ByteList before either).  They will call getId() and not getName() but this
is ok.
2. to not pin RubySymbol to a static field I Symbol.KW_REST_ARG_DUMMY is
initialized with a null RubySymbol instance.  This is a little wonky this
field may end up in IRManager eventually but it really has no visible contents
so this is probably ok for now.
    @enebo
    enebo committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    6c642aa View commit details
    Browse the repository at this point in the history