Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giac: enable checks, separate outputs #38810

Merged
merged 1 commit into from Apr 19, 2018
Merged

giac: enable checks, separate outputs #38810

merged 1 commit into from Apr 19, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Giac is 18M binary, 92M docs. Here I seperate those two outputs.

This also enables tests and adds a patch to fix them when building without GUI.

Maintainer: @symphorien

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

Thanks. Btw, I have seen you have just submitted a lot of math related PRs, do you intend to package cocoa ? It is an optional dependency of giac, it would be nice to add it here if you do so.

@timokau
Copy link
Member Author

timokau commented Apr 11, 2018

No, I'm currently packaging a lot of sage dependencies but coca is not one of them (have never heard of it).

@matthewbauer matthewbauer merged commit 1bb28f2 into NixOS:master Apr 19, 2018
@timokau timokau deleted the giac-improvements branch April 20, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @symphorien @matthewbauer @GrahamcOfBorg