Support overriding Exception#message
#5136
Merged
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CRuby, an uncaught exception messages users with the exception's message, considering if it's overriden or not.
e.g.
/tmp/vu4TBd5/647:7:in `<main>': hello (A)
A: A\n <main> at /tmp/vu4TBd5/648:7
This pull request changes JRuby behaviour similar to CRuby's.
A: hello\n <main> at /tmp/vu4TBd5/650:7
Note that if the overriden
message
method raises an exception, it shouldn't message the internal exception, but the external exception, according to CRuby Bug #14566 https://bugs.ruby-lang.org/issues/14566This pullreq already considers that.
e.g.
/tmp/vu4TBd5/655:7:in `<main>': A
A: A\n <main> at /tmp/vu4TBd5/656:7"
I'm not fluent in Java, so please let me know if there's somewhere you don't feel good! I'm more than happy to update my commit.