Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builtins.fetchGit to README.org #54

Closed
wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

No description provided.

@lukateras
Copy link
Member Author

No problem, I've turned this into a pull request.

Inline backtick equivalent is ~~, to make a code block, one could use #+BEGIN_SRC and #+END_SRC.

@lukateras
Copy link
Member Author

lukateras commented Apr 6, 2018

On the change itself, I think channels are more appropriate for this kind of thing than evaluation-time builtins.fetchGit, being more user-transparent, having rollback mechanism, and only being updated explicitly, and properly working without internet connection.

If it is decided that updating this repo on nixos-rebuild --upgrade switch is a good idea, we could add .update-on-nixos-rebuild to the root of this repository.

@lukateras
Copy link
Member Author

lukateras commented Apr 6, 2018

(As I've opened this pull request, I'm not sure you are subscribed to it, so just in case, cc @Mic92).

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

Rollbacks do not work with fetchgit?

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

The advantage of fetchgit is that one does not have to manually add channels. So I think this is a reasonable alternative to channel.

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

@lukateras
Copy link
Member Author

lukateras commented Apr 6, 2018

There is nothing comparable to channel rollback with builtins.fetchGit, nixos-rebuild rollback still works. But it's important to have channel rollback too, if someone updated nixos-hardware and that resulted in a breakage, but they still want to use newer nixos channel.

I'm concerned that it fetches at eval time on every rebuild, while nixos-rebuild --upgrade switch is explicit. I think that we would break user expectations by recommending that, and cause slow eval. It also couples location of the overlay (in that case, link) with its interface, making testing new profiles/patches that are not present on master branch very inconvenient, while with current approach one could just point NIX_PATH to it, e.g. sudo nixos-rebuild -I nixos-hardware=https://github.com/Mic92/nixos-hardware/archive/patch-1.tar.gz switch

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

I will still use fetchgit because I don't want manually setup channel every time. I don't know why documenting alternatives is such a big deal. fetchgit can also point other branches and even local checkouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants