Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing eval-okay-regex-split.exp test file #2049

Merged
merged 1 commit into from Apr 9, 2018
Merged

Add missing eval-okay-regex-split.exp test file #2049

merged 1 commit into from Apr 9, 2018

Conversation

mightybyte
Copy link
Contributor

I noticed that this file was absent for some reason.

@shlevy
Copy link
Member

shlevy commented Apr 7, 2018

I think the way the tests work is that if there's no .exp it just checks that the evaluation succeeds?

@mightybyte
Copy link
Contributor Author

Well, this test case has one: https://github.com/NixOS/nix/blob/master/tests/lang/eval-okay-regex-match.exp

@shlevy
Copy link
Member

shlevy commented Apr 9, 2018

Is this causing any issues? Test suite seems to run fine here.

@shlevy shlevy added the triaged label Apr 9, 2018
@shlevy shlevy self-assigned this Apr 9, 2018
@mightybyte
Copy link
Contributor Author

I'm working on tools that import and run these tests automatically, so it would be nice to have uniformity.

@shlevy shlevy merged commit 72902ec into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shlevy shlevy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mightybyte @shlevy