grafana-reporter: init at 2.0.1 #38514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build grafana_reporter |
|
Success on x86_64-linux (full log) Attempted: grafana_reporter Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: grafana_reporter Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: grafana_reporter Partial log (click to expand)
|
disassembler
force-pushed
the
grafana-reporter
branch
2 times, most recently
from
e23a223
to
575dc38
Compare
infinisil
requested changes
Apr 8, 2018
| systemd.services.grafana_reporter = { | ||
| description = "Grafana Reporter Service Daemon"; | ||
| wantedBy = ["multi-user.target"]; | ||
| after = ["networking.target"]; |
There was a problem hiding this comment.
I'm pretty sure it's network.target, I can't find a networking.target unit in my systemctl. The grafana and openfire services are the only ones using networking.target, so that should be fixed too at some point.
| wantedBy = ["multi-user.target"]; | ||
| after = ["networking.target"]; | ||
| serviceConfig = { | ||
| ExecStart = "${pkgs.grafana_reporter.bin}/bin/grafana-reporter -proto ${cfg.grafana.protocol}:// -ip ${cfg.grafana.addr}:${toString cfg.grafana.port} -port :${toString cfg.port} -templates ${cfg.templateDir}"; |
There was a problem hiding this comment.
I occasionally like to do
{
ExecStart = let args = concatStringsSep [
"-proto ..."
...
]; in "grafana-reporter ${args}";
}To make the line shorter.
|
Ping? |
disassembler
force-pushed
the
grafana-reporter
branch
from
575dc38
to
5b30cd7
Compare
infinisil
approved these changes
Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds grafana-reporter tool that generates PDF from grafana dashboard.
I'll be pushing a nixos module to this PR soon as well.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)