clementine: provide free derivation by default #38513

Ma27 · 2018-04-06T15:24:06Z

Motivation for this change

The clementine package is actually released under Apache license, but
requires the unfree libspotify package to build.

Now nixpkgs.clementine points to the free derivation and
nixpkgs.clementineUnfree has been introduced for the package bundled
with spotify support.

Fixes #38315

Note: I had to revert commit ca54d50 as it broke clementine previously (see the Hydra logs at https://hydra.nixos.org/build/72403466)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

This reverts commit ca54d50.

GrahamcOfBorg · 2018-04-06T16:20:36Z

Success on x86_64-linux (full log)

Attempted: clementine

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1
shrinking /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin/clementine
shrinking /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin/clementine-tagreader
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin
patching script interpreter paths in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1
checking for references to /build in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1...
/nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1

GrahamcOfBorg · 2018-04-06T16:39:37Z

Success on aarch64-linux (full log)

Attempted: clementine

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1
shrinking /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin/clementine-tagreader
shrinking /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin/clementine
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin
patching script interpreter paths in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1
checking for references to /build in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1...
/nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1

FRidh · 2018-04-07T05:49:49Z

pkgs/applications/audio/clementine/default.nix

    '';
    enableParallelBuilding = true;
    meta = with stdenv.lib; {
      homepage = http://www.clementine-player.org;
      description = "Spotify integration for Clementine";
      # The blob itself is Apache-licensed, although libspotify is unfree.
-      license = licenses.asl20;
+      # Therefore the license will be marked as `unfree` because of its dependencies.
+      license = licenses.unfree;


Not sure whether that is needed. Because of its dependency on libspotify the leaf will be unfree and thus this package would fail to build or install because it requires unfree software.

I'll change that for now. The original issue was filed because of the package shipped with a free license, but libspotify broke the evaluation on systems which disallow unfree packages. However the affected package is now named clementineUnfree, so I guess that it should be sufficiently obvious :)

The `clementine` package is actually released under Apache license, but requires the unfree `libspotify` package to build. Now `nixpkgs.clementine` points to the free derivation and `nixpkgs.clementineUnfree` has been introduced for the package bundled with spotify support. Fixes NixOS#38315

GrahamcOfBorg · 2018-04-07T09:55:01Z

Success on x86_64-linux (full log)

Attempted: clementine

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1
shrinking /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin/clementine-tagreader
shrinking /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin/clementine
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1/bin
patching script interpreter paths in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1
checking for references to /tmp/nix-build-clementine-free-1.3.1.drv-0 in /nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1...
/nix/store/r7m7rnsp0dmpx24p5yjz6cbwq5kpf6z5-clementine-free-1.3.1

GrahamcOfBorg · 2018-04-07T10:11:33Z

Success on aarch64-linux (full log)

Attempted: clementine

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1
shrinking /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin/clementine-tagreader
shrinking /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin/clementine
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1/bin
patching script interpreter paths in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1
checking for references to /build in /nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1...
/nix/store/xcr05zy9xr94ggsn1vvlfl4srn6sifmx-clementine-free-1.3.1

The current checklist for filing new patches suggests to run `nox-review wip` to ensure that the current change (e.g. package bumps) don't break package bumps: https://github.com/NixOS/nixpkgs/blob/e1dee4efcbffc72260025078bf8297a3b732509c/.github/PULL_REQUEST_TEMPLATE.md I experienced this behavior from time to time (see NixOS/nixpkgs#38513 or NixOS/nixpkgs#38361) which cost me some extra time to spot the reasons for additional breackage. Running `nox-review wip` can be quite time consuming, especially when bumping packages that trigger a mass-rebuild or a stdenv rebuild, *however* this patch helps to reduce the risk of additional breackage caused by unwanted package bumps.

matthewbauer · 2018-04-09T02:38:49Z

I'm not sure if this is the right thing to do. Shouldn't we just add a config option to "celementine", something like "withSpotify"? You can just call it with clementine.overideAttrs { withSpotify = true; } etc.

Ma27 · 2018-04-09T06:12:37Z

So you propose to disable the unfree build by default?
What I’m trying to do is to use the entirely free clementine build by default and clementineUnfree comes with libspotify. Both variants will be prebuilt on Hydra so noone will have to recompile locally.
I may be misunderstanding you, but why would you want to solve this with override parameters only?

Mic92 · 2018-04-09T07:59:21Z

A config option is possible, but less convenient/discoverable at the moment without module system.
Hydra does not build unfree packages, but this should not be a big deal here.

FRidh · 2018-04-09T17:22:38Z

A flag is fine as well, as long as the unfree parts are off by default.

I may be misunderstanding you, but why would you want to solve this with override parameters only?

We can't have top-level attributes for every combination of parameters.

Ma27 · 2018-04-09T17:27:24Z

previously we used clementine and clementineFree as toplevel attributes, I didn't introduce a new one. In order to remain consistent I justed swapped both attributes and renamed clementineFree accordingly to clementineUnfree.

Revert "chromaprint: 1.3.2 -> 1.4.3"

c1f1d86

This reverts commit ca54d50.

GrahamcOfBorg added 6.topic: nixos 8.has: changelog 8.has: documentation 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 6, 2018

FRidh reviewed Apr 7, 2018

View reviewed changes

FRidh requested a review from ttuegel April 7, 2018 05:50

Ma27 force-pushed the clementine-license-fixes branch from 8f2a469 to ef5e212 Compare April 7, 2018 09:36

Ma27 mentioned this pull request Apr 7, 2018

up.sh: run nox-review wip before commiting nix-community/nixpkgs-update#39

Closed

Mic92 merged commit c757928 into NixOS:master Apr 9, 2018

Ma27 deleted the clementine-license-fixes branch April 9, 2018 08:00

Ma27 mentioned this pull request Apr 24, 2018

Clementine fails to build after chromaprint update #39179

Closed

jerith666 mentioned this pull request Jun 16, 2018

clementine: misses gstreamer plugins to play flac. #39960

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clementine: provide free derivation by default #38513

clementine: provide free derivation by default #38513

Ma27 commented Apr 6, 2018 •

edited

GrahamcOfBorg commented Apr 6, 2018

GrahamcOfBorg commented Apr 6, 2018

FRidh Apr 7, 2018

Ma27 Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

matthewbauer commented Apr 9, 2018

Ma27 commented Apr 9, 2018

Mic92 commented Apr 9, 2018 •

edited

FRidh commented Apr 9, 2018

Ma27 commented Apr 9, 2018

clementine: provide free derivation by default #38513

clementine: provide free derivation by default #38513

Conversation

Ma27 commented Apr 6, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Apr 6, 2018

GrahamcOfBorg commented Apr 6, 2018

FRidh Apr 7, 2018

Choose a reason for hiding this comment

Ma27 Apr 7, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

matthewbauer commented Apr 9, 2018

Ma27 commented Apr 9, 2018

Mic92 commented Apr 9, 2018 • edited

FRidh commented Apr 9, 2018

Ma27 commented Apr 9, 2018

Ma27 commented Apr 6, 2018 •

edited

Mic92 commented Apr 9, 2018 •

edited