Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 3.5.1 -> 3.5.2 #38508

Closed
wants to merge 1 commit into from
Closed

platformio: 3.5.1 -> 3.5.2 #38508

wants to merge 1 commit into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Apr 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested a review from FRidh as a code owner April 6, 2018 11:57
@dotlambda dotlambda self-assigned this Apr 6, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

@GrahamcOfBorg eval

@dotlambda
Copy link
Member

If I'm not mistaken, platformio is not intended to be used as a python module, i.e. import platformio. Since it doesn't work with click>=6, it will fail to build as soon as #38483 is merged. Also see platformio/platformio-core#349.
Therefore, I suggest moving platformio out of pythonPackages into a file called pkgs/development/arduino/platformio/core.nix (because the GitHub repo is called platformio-core). We can then pin the click version such as it is done e.g. here.

@dotlambda
Copy link
Member

Update included in #38483.

@dotlambda dotlambda closed this Apr 7, 2018
@dotlambda
Copy link
Member

Regarding platformio packaging situation: #38571.

@oxzi oxzi deleted the platformio-3.5.2 branch April 8, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@dotlambda dotlambda

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @Mic92 @dotlambda @GrahamcOfBorg