Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark inputs of styling plugin as required #2303

Merged
merged 1 commit into from Oct 14, 2020
Merged

Conversation

micgro42
Copy link
Collaborator

@micgro42 micgro42 commented Apr 6, 2018

As recommended by @Klap-in. While this cannot ensure that the value is valid, it should prevent accidental saving of an empty field, which crashes the less compiler.

I am not aware of any use cases where saving an empty field would be valid/desirable. However, that doesn't mean that there aren't any. Thoughts?

Fixes #2246

While this cannot ensure that the value is valid, it should prevent
accidental saving of an empty field, which crashes the less compiler.

Fixes #2246
@splitbrain splitbrain merged commit 126b50b into master Oct 14, 2020
@splitbrain splitbrain deleted the requireStyleValue branch October 14, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundled styling plugin allows saving empty color, which crashes LESS/CSS parser
2 participants