Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.24.0 -> 1.25.0 #38511

Merged
merged 1 commit into from Apr 8, 2018
Merged

rustc: 1.24.0 -> 1.25.0 #38511

merged 1 commit into from Apr 8, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Apr 6, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2018

@GrahamcOfBorg eval

@bkchr
Copy link
Contributor Author

bkchr commented Apr 6, 2018

@Mic92 could you tell graham to also build it?

@LnL7
Copy link
Member

LnL7 commented Apr 6, 2018

Ofborg builds will timeout on large builds like rustc, if that's what you're talking about. I'm testing on my hydra instance.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 6, 2018

@LnL7: Yeah that was what I was talking about. Ty. I already build x86_64 locally and that worked, but I'm really interested on aarch64, because the 1.24 does not build anymore on Hydra.

LnL7
LnL7 reviewed Apr 8, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested linux and darwin, including a firefox build.

@LnL7 LnL7 merged commit 6b0ff4e into NixOS:master Apr 8, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

breaks aarch64: https://hydra.nixos.org/build/72562211/nixlog/1
test [debuginfo-gdb] debuginfo/by-value-self-argument-in-trait-impl.rs ... FAILED

I am tempted to just delete this file.

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

By the way we also have horse power here to build rust without timeouts: https://github.com/nix-community/aarch64-build-box

Access is just a pull request away.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 9, 2018 •
edited

@Mic92 yeah I know and I already have a pr open: NixOS/aarch64-build-box#22 :D
I also opened an issue upstream for the aarch64 building issue: rust-lang/rust#49807
Yeah, maybe we could start with deleting the file and wait for upstream, if they can help us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @Mic92 @LnL7 @GrahamcOfBorg