Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ahoviewer: 1.4.9 -> 1.5.0; add useUnrar option #37657

Merged
merged 2 commits into from Mar 25, 2018
Merged

ahoviewer: 1.4.9 -> 1.5.0; add useUnrar option #37657

merged 2 commits into from Mar 25, 2018

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Mar 22, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build ahoviewer

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ahoviewer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ahoviewer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: ahoviewer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@matthewbauer
Copy link
Member

"unrar" is unfree. Can you see if it's possible to get rid of unrar in buildInputs? (try --disable_rar in configureFlags)

@xzfc
Copy link
Contributor Author

xzfc commented Mar 25, 2018

@GrahamcOfBorg build ahoviewer

@xzfc xzfc changed the title ahoviewer: 1.4.9 -> 1.5.0 ahoviewer: 1.4.9 -> 1.5.0; add useUnrar option Mar 25, 2018
@xzfc
Copy link
Contributor Author

xzfc commented Mar 25, 2018

@GrahamcOfBorg build ahoviewer

@xzfc
Copy link
Contributor Author

xzfc commented Mar 25, 2018

@matthewbauer I've added useUnrar option to the package, defaulted to false.
Do not know why @GrahamcOfBorg ignores my commands.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build ahoviewer

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ahoviewer

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ahoviewer

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-ahoviewer-1.5.0.drv-0/source'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0
shrinking /nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0/bin/.ahoviewer-wrapped
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0/bin
patching script interpreter paths in /nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0
checking for references to /tmp/nix-build-ahoviewer-1.5.0.drv-0 in /nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0...
/nix/store/gcx8fp8s7cbsxmqfvqqg587l6wsg056j-ahoviewer-1.5.0

@matthewbauer matthewbauer merged commit c276b45 into NixOS:master Mar 25, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ahoviewer

Partial log (click to expand)

   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_errors)
   Compiling backtrace v0.3.4
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.24.0-src/src/libproc_macro)
   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.24.0-src/src/libsyntax_ext)
building of '/nix/store/6mm6pr840z429p4l9mk62gh7mr6khj3k-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/68kg61kq3qlbfxdjan2s7hrd0fidyxri-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2fvhpqf8jjcdzvifkpipb5r41pwvxl2d-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kgqw75m9man6hfhbmz5za0lnppdnw2wi-ahoviewer-1.5.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/kgqw75m9man6hfhbmz5za0lnppdnw2wi-ahoviewer-1.5.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xzfc @matthewbauer @GrahamcOfBorg