Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jfbview: 0.5.4 -> 0.5.5 #37654

Merged
merged 2 commits into from Apr 1, 2018
Merged

jfbview: 0.5.4 -> 0.5.5 #37654

merged 2 commits into from Apr 1, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Mar 22, 2018 •
edited

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

@ryantm
jfbview: 0.5.4 -> 0.5.5
7bd403a 
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

- built on NixOS
/tmp/tmp.L8dOowJKxk /home/ryantm/.cache/nixpkgs
/home/ryantm/.cache/nixpkgs
- Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
- directory tree listing: https://gist.github.com/d0c7d347a8f411b60cafc2bc64a3bb19
@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: jfbview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: jfbview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Mar 22, 2018

This package was marked broken in #36654 , but has recently been fixed according to upstream maintainer. @ryantm how does your tool handle packages marked as broken? Did it really successfully build this before making the PR (according to ofborg above it's still marked as broken).
But in this case it might be worth trying to see if it builds with broken=false.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: jfbview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@ryantm
Copy link
Member Author

ryantm commented Mar 22, 2018

@xeji I think my bot might be using my nixpkgs config which has

allowUnfree = true;
allowBroken = true;

in it.

It really successfully built it. See the directory tree listing for what is in the result.

@xeji
Copy link
Contributor

xeji commented Mar 22, 2018 •
edited

Cool. Builds and seems to work.
In general, what do you think is the best way to handle this (probably rare) case:

  • let the bot set broken=false after a successful build ?
  • add a note in the PR that it requires human intervention ?
  • just do nothing and hope someone notices before merging that broken=true ?

@ryantm
Copy link
Member Author

ryantm commented Mar 23, 2018

I prefer the human intervention approach. I can use nix eval to check that broken is set and warn about it in the PR text.

@xeji
Copy link
Contributor

xeji commented Mar 23, 2018

Think so too. If it was broken it should be manually tested before merging.

@ryantm ryantm mentioned this pull request Mar 23, 2018
Closed
@xeji
Copy link
Contributor

xeji commented Mar 25, 2018

Please remove these lines before merging, package is no longer broken:

# incompatible with latest mupdf, see https://github.com/jichu4n/JFBView/issues/17
broken = true;

@ryantm
Copy link
Member Author

ryantm commented Mar 26, 2018

@xeji done.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jfbview

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5
shrinking /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5/bin/jfbview
shrinking /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5/bin/jpdfcat
shrinking /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5/bin/jpdfgrep
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5/bin
patching script interpreter paths in /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5
checking for references to /build in /nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5...
/nix/store/76za7m39a4rm5023zsh61vc9xvdv1h9w-jfbview-0.5.5

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: jfbview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jfbview

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5
shrinking /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5/bin/jpdfgrep
shrinking /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5/bin/jpdfcat
shrinking /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5/bin/jfbview
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5/bin
patching script interpreter paths in /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5
checking for references to /build in /nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5...
/nix/store/n5hl8sdmk5zs8f7wk2k7v2va7xim2dcl-jfbview-0.5.5

@matthewbauer matthewbauer merged commit 3f47ee2 into NixOS:master Apr 1, 2018
@ryantm ryantm deleted the auto-update/jfbview branch April 1, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantm @GrahamcOfBorg @xeji @matthewbauer