CODEOWNERS: Add Profpatsch to /lib/generators.nix #37694
Conversation
I’d like to be notified of changes so I can ensure the API always follows the same patterns. Later (more specific) files replace more general codeowners [according to the documentation](https://help.github.com/articles/about-codeowners/), so I also listed `edolstra` and `nbp` again.
There was a problem hiding this comment.
I am against this change. The CODEOWNERS file has one clear purpose: to describe who owns what. We should not misuse it just to receive notifications. If one wants notifications, we can look into another mechanism (like running our own instance of the mention-bot).
Well, since I wrote that module and am the only contributor so far (apart from a few minor treewide changes), I do consider myself the “owner”, insofar as I have an substantial interest in reviewing proposed changes to the file. |
That was not obvious from the PR.
I'm as maintainer not so much interested in the actual modules, that is up to the module maintainers (when they have one), but I am, in the structure. |
Yes, I should have clarified that. |
I’d like to be notified of changes so I can ensure the API always follows the same patterns.
Later (more specific) files replace more general codeowners according to the documentation, so I also listed
edolstraandnbpagain.