Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document fetchGit. #2005

Merged
merged 1 commit into from Mar 27, 2018
Merged

Document fetchGit. #2005

merged 1 commit into from Mar 27, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Mar 22, 2018

Fixes #1981.

@shlevy shlevy requested a review from edolstra March 22, 2018 23:12
@shlevy
Copy link
Member Author

shlevy commented Mar 22, 2018

cc @chris-martin

@chris-martin
Copy link
Contributor

Just what I was asking for, thanks!

@teto
Copy link
Member

teto commented Mar 23, 2018 •
edited

it could be nice to describe what happens when fetching from a local repository .What about unstaged modifications etc.

edolstra
edolstra reviewed Mar 23, 2018
View reviewed changes
doc/manual/expressions/builtins.xml Outdated

<listitem>
<para>
Fetch a path from git. <replaceable>args</replaceable> can be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: there's a tab here :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@edolstra edolstra merged commit e01c01f into NixOS:master Mar 27, 2018
@shlevy shlevy deleted the fetchgit-docs branch March 27, 2018 14:24
@grahamc
Copy link
Member

grahamc commented Apr 1, 2018

We should backport these to 2.0-maint for the next release.

@shlevy
Copy link
Member Author

shlevy commented Apr 1, 2018

@grahamc Waiting on a resolution to NixOS/rfcs#28 then I'll get a lot ready.

infinisil added a commit to tweag/nix that referenced this pull request Oct 25, 2023
@infinisil
doc: Fix fetchGit default name
65668da 
fetchGit never used the basename of the URL as the name by default.
The mistake was introduced when docs were written in NixOS#2005.
@infinisil infinisil mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra edolstra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shlevy @chris-martin @teto @grahamc @edolstra