gettext: don't add -lintl on musl, either #37688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gettext won't actually provide libintl unless we go out of our way to tell it to do so [1][2]. We could add those flags on musl (as I initially did in [3]), but then we have two different libintl.h files and generally some confusion about which gettext is being used. Instead of sorting that out, for now let's just continue on without gettext providing libintl-- it's worked well enough so far. Only change that needs to be made, then, is to avoid adding -lintl on musl since there is no libintl. [1] pullmoll/void-packages@c739240 [2] https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/libintl/libintl-0.19.8.1.ebuild?id=332e48712b6521697f992f923c9c985482dd1c36#n41 [3] 729302f
|
Additional discussion: http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/127196 |
|
cc #37012 |
|
Failure on x86_64-darwin (full log) Attempted: gettext Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: gettext Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gettext Partial log (click to expand)
|
|
Sounds good for now. Do you think if we get started on #37056 there will be an opportunity to bring in musl/alpine people on stuff like this? |
|
@GrahamcOfBorg build gettext |
|
Success on aarch64-linux (full log) Attempted: gettext Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gettext Partial log (click to expand)
|
|
There we go :). |
|
Failure on x86_64-darwin (full log) Attempted: gettext Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gettext won't actually provide libintl unless we go out of
our way to tell it to do so [1][2].
We could add those flags on musl (as I initially did in [3]),
but then we have two different libintl.h files and generally
some confusion about which gettext is being used.
Instead of sorting that out, for now let's just continue on
without gettext providing libintl-- it's worked well enough so far.
Only change that needs to be made, then, is to avoid
adding -lintl on musl since there is no libintl.
[1] pullmoll/void-packages@c739240
[2] https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/libintl/libintl-0.19.8.1.ebuild?id=332e48712b6521697f992f923c9c985482dd1c36#n41
[3] dtzWill@729302f
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Sorry for not catching this earlier during review!
This unbreaks musl builds, and should be "safe" in that it preserves
prior behavior (rather than wrangling with the problem just yet).