Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing $DESTDIR when installing programs and BUILD_SHARED_LIBS=0 #2059

Merged
merged 1 commit into from Apr 9, 2018
Merged

Fix missing $DESTDIR when installing programs and BUILD_SHARED_LIBS=0 #2059

merged 1 commit into from Apr 9, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Apr 9, 2018

The rule target and dependencies properly use $(DESTDIR), but the install command didn't when BUILD_SHARED_LIBS was false. This commit adds it. I'm successfully able to run a build using DESTDIR=/path after this patch.

@andrew-d andrew-d changed the title Fix missing $DESTDIR when installing programs Fix missing $DESTDIR when installing programs and BUILD_SHARED_LIBS=0 Apr 9, 2018
@edolstra edolstra merged commit 9387163 into NixOS:master Apr 9, 2018
@andrew-d andrew-d deleted the adunham/fix-destdir branch April 9, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrew-d @edolstra