Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all dependencies to source prerequisites #2060

Merged
merged 2 commits into from Apr 9, 2018
Merged

Add all dependencies to source prerequisites #2060

merged 2 commits into from Apr 9, 2018

Conversation

IohannesArnold
Copy link
Contributor

I was trying to bootstrap the 2.0 tarball on an embedded system I was putting together and the configure script required more dependencies than the manual implies. It's entirely possible I'm doing something wrong though.

I was trying to bootstrap the 2.0 tarball on an embedded system I was putting together and the configure script required more dependencies than the manual implies. It's entirely possible I'm doing something wrong though.
@@ -28,6 +31,14 @@
distribution does not provide these, you can obtain bzip2 from <link
xlink:href="http://www.bzip.org/"/>.</para></listitem>

<listitem><para><literal>liblzma/literal>, which is provided by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot a < before /literal>

Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, looks good to me!

@@ -9,6 +9,9 @@
<itemizedlist>

<listitem><para>GNU Make.</para></listitem>

<listitem><para>Bash Shell. Bash, and no other shell, is required to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and no other shell" reads kind of oddly to me, can you say something like "the configure script relies on bashisms" or some such?

@shlevy
Copy link
Member

shlevy commented Apr 9, 2018

Thanks! Do you mind squashing these, or if I squash when I merge?

@IohannesArnold
Copy link
Contributor Author

I don't have the git repo downloaded right now, just the tarball. I made the edits over Github's interface and don't think I can squash commits with just the website. So if you could squash them while merging, that would be convenient, thanks.

@shlevy shlevy merged commit a405d25 into NixOS:master Apr 9, 2018
@IohannesArnold
Copy link
Contributor Author

If this change is merged into master will it show up on the website soon or does it have to wait until the next release? If the latter, should it also get merged into the 2.0 branch? I wrote it in reaction to the 2.0 release tarball; if anyone else is building from the 2.0 source they might appreciate having the live manual agree with the configure script...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants