Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/less: add configFile option #38629

Merged
merged 1 commit into from Apr 9, 2018
Merged

Conversation

ivanbrennan
Copy link
Member

Expose the path to a lesskey file as a module option.

Motivation for this change

This makes it possible to maintain a single lesskey file, used for both NixOS and non-nix systems. An example of how this can be done follows.

  1. Write a derivation that fetches lesskey from a known location:
{ stdenv, fetchgit }:
stdenv.mkDerivation {
  name = "foo";
  src = fetchgit { .. };
  phases = [ "unpackPhase" "installPhase" ];
  installPhase = "mkdir -p $out && cp $src/lesskey $out/lesskey";
}
  1. Set configFile option to the corresponding path:
programs.less = {
  enable = true;
  configFile = "${pkgs.foo}/lesskey";
};
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Expose the path to a lesskey file as a module option. This makes it
possible to maintain a single lesskey file, used for both NixOS and
non-nix systems. An example of how this can be done follows.

1. Write a derivation that fetches lesskey from a known location:

  { stdenv, fetchgit }:
  stdenv.mkDerivation {
    name = "foo";
    src = fetchgit { .. };
    phases = [ "unpackPhase" "installPhase" ];
    installPhase = "mkdir -p $out && cp $src/lesskey $out/lesskey";
  }

2. Set programs.less.configFile to the corresponding path:

    programs.less = {
      enable = true;
      configFile = "${pkgs.foo}/lesskey";
    };
@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

Thanks!

@ivanbrennan ivanbrennan deleted the less-configFile branch April 9, 2018 11:08
@ivanbrennan
Copy link
Member Author

@JohnAZoidberg Good idea. Please see #59517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants