ocamlPackages.js_of_ocaml-lwt: init at 3.1.0 #38637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ocamlPackages.js_of_ocaml-lwt |
|
Success on x86_64-linux (full log) Attempted: ocamlPackages.js_of_ocaml-lwt Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ocamlPackages.js_of_ocaml-lwt Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ocamlPackages.js_of_ocaml-lwt Partial log (click to expand)
|
Mic92
reviewed
Apr 10, 2018
| @@ -326,6 +326,8 @@ let | |||
|
|
|||
| js_of_ocaml-compiler = callPackage ../development/tools/ocaml/js_of_ocaml/compiler.nix {}; | |||
|
|
|||
| js_of_ocaml-lwt = callPackage ../development/tools/ocaml/js_of_ocaml/lwt.nix {}; | |||
There was a problem hiding this comment.
Probably at some point it would be worth to introduce a js_of_ocaml namespace and add abstraction to wrap packages below that automatically.
There was a problem hiding this comment.
How many would be such a “point”? I have one more such jsoo library to add.
There was a problem hiding this comment.
How many packages are applicable? Usually it is better to refactor early because the amount of refactoring increases with the number of packages.
There was a problem hiding this comment.
It could look like altcoins: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/altcoins/default.nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Required to update
eliom.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)