guake: 0.8.3 → 3.1.0 #38642
Merged
guake: 0.8.3 → 3.1.0 #38642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2018
Closed
|
Fails to build for me. If I run nix-build -A guake after applying this patch I get the error: Warning: Schema ?guake.hooks? has path ?/apps/guake/hooks/?. Paths starting with ?/apps/?, ?/desktop/? or ?/system/? are deprecated.
for f in $(find po -iname "*.mo"); do \
l="${f%%.*}"; \
lb=$(basename $l); \
install -Dm644 "$f" "/nix/store/8j992bjl427czpx78r1x3mdjaqwgr21d-guake-3.0.5/share/locale/$lb/LC_MESSAGES/guake.mo"; \
done;
# you probably want to execute this target with sudo:
# sudo make install
Installing from on your system is not recommended.
Please prefer you application package manager (apt, yum, ...)
Exception:
Traceback (most recent call last):
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
status = self.run(options, args)
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/commands/install.py", line 272, in run
with self._build_session(options) as session:
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/basecommand.py", line 72, in _build_session
insecure_hosts=options.trusted_hosts,
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/download.py", line 329, in __init__
self.headers["User-Agent"] = user_agent()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/download.py", line 93, in user_agent
from pip._vendor import distro
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 1050, in <module>
_distro = LinuxDistribution()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 595, in __init__
self._distro_release_info = self._get_distro_release_info()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 995, in _get_distro_release_info
distro_info = self._parse_distro_release_file(filepath)
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 1018, in _parse_distro_release_file
return self._parse_distro_release_content(fp.readline())
File "/nix/store/azw9ys2m2fpfzf730xjcxja890gpyp58-python3-3.6.4/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 48: ordinal not in range(128)
Traceback (most recent call last):
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/bin/.pip3-wrapped", line 12, in <module>
sys.exit(main())
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/__init__.py", line 233, in main
return command.main(cmd_args)
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/basecommand.py", line 251, in main
timeout=min(5, options.timeout)) as session:
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/basecommand.py", line 72, in _build_session
insecure_hosts=options.trusted_hosts,
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/download.py", line 329, in __init__
self.headers["User-Agent"] = user_agent()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/download.py", line 93, in user_agent
from pip._vendor import distro
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 1050, in <module>
_distro = LinuxDistribution()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 595, in __init__
self._distro_release_info = self._get_distro_release_info()
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 995, in _get_distro_release_info
distro_info = self._parse_distro_release_file(filepath)
File "/nix/store/grsdsbb6wcay289jxxmxddgp7hwsvawb-python3.6-pip-9.0.1/lib/python3.6/site-packages/pip/_vendor/distro.py", line 1018, in _parse_distro_release_file
return self._parse_distro_release_content(fp.readline())
File "/nix/store/azw9ys2m2fpfzf730xjcxja890gpyp58-python3-3.6.4/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 48: ordinal not in range(128)
make: *** [Makefile:41: install-system] Error 1
builder for '/nix/store/vibcrynznj540qaphd5sz7fq1gp6m1xn-guake-3.0.5.drv' failed with exit code 2
error: build of '/nix/store/vibcrynznj540qaphd5sz7fq1gp6m1xn-guake-3.0.5.drv' failedGranted that's on deepin I'm going to boot NixOS and see if it happens on that. |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Works on NixOS 18.03, however. |
|
How do I install this so that the guake binary appears in $HOME/.nix-profile/bin? Running: cd nixpkgs/pkgs/applications/misc/guake
nix-env -if default.nixreturns: error: cannot auto-call a function that has an argument without a default value ('stdenv')but to my knowledge |
|
Failure on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
Weird. Could you try adding
I would use cd nixpkgs
nix-env -f . -iA guake |
|
I'm new to Nix and functional package management, what do you mean by glibcLocales -> nativeBuildInputs? Do I type |
|
I meant adding it to the list in the expression – at the moment, there is and you would change it to |
|
I also assume that the export LC_ALL="en_US.UTF-8"
nix-env -f . -iA guake |
--- a/pkgs/applications/misc/guake/default.nix
+++ b/pkgs/applications/misc/guake/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, python3, gettext, gobjectIntrospection, wrapGAppsHook
+{ stdenv, fetchFromGitHub, python3, gettext, gobjectIntrospection, wrapGAppsHook, glibcLocales
, gtk3, keybinder3, libnotify, libutempter, vte }:
let
@@ -14,12 +14,14 @@
sha256 = "02gx17z9bsn3my3v54w0yjjr0g43lgpd2aw87377p39hjw7ii29k";
};
- nativeBuildInputs = [ gettext gobjectIntrospection wrapGAppsHook python3.pkgs.pip ];
+ nativeBuildInputs = [ gettext gobjectIntrospection wrapGAppsHook python3.pkgs.pip glibcLocales ];
buildInputs = [ gtk3 keybinder3 libnotify python3 vte ];
propagatedBuildInputs = with python3.pkgs; [ dbus-python pbr pycairo pygobject3 ];
+ LC_ALL = "en_US.UTF-8"; # maybe fixes weird encoding error, see https://github.com/NixOS/nixpkgs/pull/38642#issuecomment-379727699
+
PBR_VERSION = version; # pbr needs either .git directory, sdist, or env var
makeFlags = [ |
|
Presently these changes, if I've implemented them right, gives: error: undefined variable 'glibcLocales' at /data/GitHub/others/nixpkgs/pkgs/applications/misc/guake/default.nix:17:85here's my modified default.nix file for guake: https://gist.github.com/a6f152183e58b3c10423efe3b77d1406. |
|
You forgot to add it as parameter to the function, see the change of the line 1. |
|
Great! It works now. |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
Closed
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: guake Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: guake Partial log (click to expand)
|
|
This bot is driving me mad with activity, so unsubscribing, if you's need me please mention me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Another step in getting nixpkgs rid of
GConf,gtk2and other archaisms.Closes: #19576, #38634
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)