Refactor out variable name #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this just a coincidence #5895 😮 |
|
@sdogruyol yes, and no :) I wanted to do this refactor since my previous PR and yours motivated me to action ;) |
|
Greet to see that I'm not the only one thinking this 👍 @Sija |
RX14
approved these changes
Apr 2, 2018
straight-shoota
approved these changes
Apr 4, 2018
sdogruyol
approved these changes
Apr 5, 2018
|
milestone is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
outas variable name, since it's a reserved keyword.Btw, shouldn't this give a compiler error?