bepasty: make it a package again #38300

Lassulus · 2018-04-01T16:41:23Z

this fixes running bepasty with gunicorn, which is needed for
services.bepasty

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-04-01T16:56:07Z

Success on x86_64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

writing entry points to bepasty.egg-info/entry_points.txt
reading manifest file 'bepasty.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'docs/build'
writing manifest file 'bepasty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK

GrahamcOfBorg · 2018-04-01T17:26:23Z

Failure on x86_64-darwin (full log)

Attempted: bepasty

Partial log (click to expand)

make[3]: Entering directory '/private/tmp/nix-build-rustc-1.24.0.drv-0/rustc-1.24.0-src/build/x86_64-apple-darwin/llvm/build'
[ 32%] Building CXX object lib/Transforms/Coroutines/CMakeFiles/LLVMCoroutines.dir/Coroutines.cpp.o
[ 32%] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopLoadElimination.cpp.o
[ 32%] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/InferFunctionAttrs.cpp.o
building of '/nix/store/xf4jw7a54gn7dxry8qqgb8vp0llqc8pv-rustc-1.24.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/3ga07ndrczi8v8chj01hp74n8jfavs83-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9413l1rvnrnvwa2nzpm0zhbd94pcyk8f-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nmw4wj9rz1wna5v080h6aq9lcq65yby2-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2djriqzrwr3j9r9bqs0h3kz3n7a1v5xs-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/2djriqzrwr3j9r9bqs0h3kz3n7a1v5xs-python2.7-bepasty-0.4.0.drv' failed

GrahamcOfBorg · 2018-04-01T18:04:22Z

Failure on aarch64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

   Compiling backtrace v0.3.4
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.24.0-src/src/libproc_macro)
   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.24.0-src/src/libsyntax_ext)
building of '/nix/store/whsyh46wr0zfkw420xcc8ffgahszsd80-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/nfjkyviyyy9ly6hq1pj5wzy6qxmd491n-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gcfp76fva6nhz86042ivcnq23dza7cgi-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/dpxr3s8mscknnmagwbc3dr4vdpa48d0m-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/99m2kmgjpqi93k3fscmvmsq18m0mfzqi-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/99m2kmgjpqi93k3fscmvmsq18m0mfzqi-python2.7-bepasty-0.4.0.drv' failed

dotlambda · 2018-04-07T21:46:01Z

I'm not really sure what the best option is in this case. /cc @FRidh

The relevant lines from the systemd service:

        systemd.services."bepasty-server-${name}-gunicorn" = {
          environment = let
            penv = python.buildEnv.override {
              extraLibs = [ bepasty gevent ];
            };
          in {
            BEPASTY_CONFIG = "${server.workDir}/bepasty-${name}.conf";
            PYTHONPATH= "${penv}/${python.sitePackages}/";
          };
          ExecStart = ''${gunicorn}/bin/gunicorn bepasty.wsgi --name ${name} ..."
        };

FRidh · 2018-04-08T06:06:12Z

This is an interesting issue. Bepasty is a server, so considered an application. The service works by creating and setting the PYTHONPATH environment variable, pointing to a a Python env. buildEnv will only include libraries and not applications.

I think the solution here is indeed to revert back to buildPythonPackage.

@Lassulus can you include a comment stating that buildPythonPackage needs to be used with a reference to this PR?

FRidh · 2018-04-08T06:48:31Z

python.buildEnv will only include libraries as of 40851a4.

Lassulus · 2018-04-09T20:21:56Z

@FRidh like this? I'm not sure I got what you mean

dotlambda · 2018-04-09T20:24:34Z

I think an inline comment (in the code, not the commit message) would be better. And please add a link to this PR.

this fixes running bepasty with gunicorn, which is needed for services.bepasty

GrahamcOfBorg · 2018-04-09T20:41:29Z

Success on aarch64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'docs/build'
writing manifest file 'bepasty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/dc3kpwjzriqvqdifplw3gn069g0wg3mr-python2.7-bepasty-0.4.0

GrahamcOfBorg · 2018-04-09T21:14:57Z

Failure on x86_64-darwin (full log)

Attempted: bepasty

Partial log (click to expand)

   Compiling rustc_privacy v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_privacy)
   Compiling rustc_save_analysis v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_save_analysis)
   Compiling rustc_borrowck v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_borrowck)
   Compiling rustc_trans_utils v0.0.0 (file:///private/tmp/nix-build-rustc-1.25.0.drv-0/rustc-1.25.0-src/src/librustc_trans_utils)
building of '/nix/store/nvxlbn91xd5aixfkqkkd6baiy19pr6gs-rustc-1.25.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/nxr2zz5skkdww5bcgljkb1m6y7bi75lm-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bfcawq8gx831ylnafd8n96ayxmi5ajsq-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/annfc2hnmzcbddmqj865f1hc1kb8fc28-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x2g2xx2sfa3im9ixh8mkjhw757h4z26h-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/x2g2xx2sfa3im9ixh8mkjhw757h4z26h-python2.7-bepasty-0.4.0.drv' failed

GrahamcOfBorg · 2018-04-09T21:57:10Z

Failure on x86_64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

test [compile-fail] compile-fail-fulldeps/gated-quote.rs ... ok
test [compile-fail] compile-fail-fulldeps/gated-macro-reexports.rs ... ok
test [compile-fail] compile-fail-fulldeps/issue-18986.rs ... ok
test [compile-fail] compile-fail-fulldeps/explore-issue-38412.rs ... ok
building of '/nix/store/36rq4v2m89p1r1i8vv4lh9ay89pangil-rustc-1.25.0.drv' timed out after 4000 seconds
cannot build derivation '/nix/store/hrbjq2kvdyzpf96q608wiqfcf0hw7vdc-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qr7kxbwwad58zh5dhfv9mkzqp0qjffas-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xrcl7p58v9h34xi3ccs501yw4a6cvzc9-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f12qb0qgba5iaqr98sb4sm11yz72578x-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/f12qb0qgba5iaqr98sb4sm11yz72578x-python2.7-bepasty-0.4.0.drv' failed

GrahamcOfBorg · 2018-04-11T13:57:30Z

Failure on aarch64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file src/libstd/sys_common/thread_info.rs.rej
builder for '/nix/store/7ns5z1p4gnzv6s2x056b8a6bh33g42ns-rustc-1.25.0.drv' failed with exit code 1
cannot build derivation '/nix/store/vsx7yh0j55abc3hf0fr0n328447kgq70-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vrb1n4b3nyl4z7gk5mq8hcg1vnmbzymw-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4lb1gypmnk9cmb0mx8fq2jxwsvkyc293-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9s7xfli54fwm6rmbkh91wlj4vi22kh9h-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9s7xfli54fwm6rmbkh91wlj4vi22kh9h-python2.7-bepasty-0.4.0.drv' failed

GrahamcOfBorg · 2018-04-11T14:13:09Z

Failure on x86_64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file src/libstd/sys_common/thread_info.rs.rej
builder for ‘/nix/store/y2qfvhnrq8ypnha05qsdg9xdghw9xhgr-rustc-1.25.0.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/g6dbhzp33465pwl5403m86qyiwkrcksd-cargo-0.26.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/qvv4nakvn7zsj1faz33807c1dfj14rb5-geckodriver-unstable-2018-02-24.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/c2wjnaq3sszkk5ssqny54f4yxikcx0r8-python2.7-selenium-3.6.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/jh1gc9xbkhy0p315zbzyswahnr79kh1j-python2.7-bepasty-0.4.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/jh1gc9xbkhy0p315zbzyswahnr79kh1j-python2.7-bepasty-0.4.0.drv’ failed

GrahamcOfBorg · 2018-04-11T14:55:41Z

Failure on x86_64-darwin (full log)

Attempted: bepasty

Partial log (click to expand)

cannot build derivation '/nix/store/nzqckphzq2czj7x1d1w4z4ibmxmj9gbp-python2.7-cryptography-2.2.2.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/gap30p9qbhic6lhyb1nscns7bb1qyg3v-geckodriver-unstable-2018-02-24.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/kqw320qf86brzz2pbzdk786byq83m40i-python2.7-pyOpenSSL-17.5.0.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/p8bx957fxqzyz6ciabd2xxnpl979kwdv-python2.7-selenium-3.6.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/zvf8rblpvvdgyyl8js900kgavf13ihvb-python2.7-urllib3-1.22.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/mcsk10286pcwz249zsd2jwy7amvd2w36-python2.7-requests-2.18.4.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/ll4w9salcx65c7hlyi1n1c8b8rgg85jf-python2.7-Werkzeug-0.14.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/p1xq2am0f93wvwr2lkw19l6l78d81k5f-python2.7-Flask-0.12.2.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/wql0pzj11g7ks4h0jgriwy23k41csvdm-python2.7-bepasty-0.4.0.drv': 17 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/wql0pzj11g7ks4h0jgriwy23k41csvdm-python2.7-bepasty-0.4.0.drv' failed

dotlambda · 2018-04-11T15:05:41Z

@GrahamcOfBorg build bepasty

GrahamcOfBorg · 2018-04-11T16:06:39Z

Failure on aarch64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

   Compiling backtrace v0.3.5
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.25.0-src/src/libproc_macro)
   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_ext)
building of '/nix/store/0p4h4m63ki245n14vpk2xihn23lq1a4a-rustc-1.25.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/apcj2slll2axzpsnpyw7qxq0mymqdhly-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1frdm3sp5axcs2jvp4sq401r2jn02pcb-geckodriver-unstable-2018-02-24.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/plax67aadgskxwwwpz3insljlgs9siwl-python2.7-selenium-3.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6wxgshd9a0z52w8imgqpsv18sm3krqdy-python2.7-bepasty-0.4.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6wxgshd9a0z52w8imgqpsv18sm3krqdy-python2.7-bepasty-0.4.0.drv' failed

GrahamcOfBorg · 2018-04-11T17:18:17Z

Success on x86_64-linux (full log)

Attempted: bepasty

Partial log (click to expand)

reading manifest file 'bepasty.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'docs/build'
writing manifest file 'bepasty.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/zb28wj756wbhzbzgk42yibcqdxi291ga-python2.7-bepasty-0.4.0

dotlambda · 2018-04-11T21:25:22Z

Should this be backported to 18.03?

Lassulus · 2018-04-12T06:44:43Z

@dotlambda yes, please

dotlambda · 2018-04-12T06:50:13Z

Backported in 1092f6d.

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 1, 2018

FRidh added 6.topic: python 0.kind: regression Something that worked before working no longer labels Apr 8, 2018

Lassulus force-pushed the bepasty-package branch from 4bf79c3 to e3a8c59 Compare April 9, 2018 20:21

GrahamcOfBorg removed the 6.topic: python label Apr 9, 2018

bepasty: make it a package again

9a182f5

this fixes running bepasty with gunicorn, which is needed for services.bepasty

Lassulus force-pushed the bepasty-package branch from e3a8c59 to 9a182f5 Compare April 11, 2018 12:55

dotlambda merged commit 4889d79 into NixOS:master Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bepasty: make it a package again #38300

bepasty: make it a package again #38300

Lassulus commented Apr 1, 2018 •

edited

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

dotlambda commented Apr 7, 2018

FRidh commented Apr 8, 2018

FRidh commented Apr 8, 2018

Lassulus commented Apr 9, 2018

dotlambda commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

dotlambda commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

dotlambda commented Apr 11, 2018

Lassulus commented Apr 12, 2018

dotlambda commented Apr 12, 2018

bepasty: make it a package again #38300

bepasty: make it a package again #38300

Conversation

Lassulus commented Apr 1, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

dotlambda commented Apr 7, 2018

FRidh commented Apr 8, 2018

FRidh commented Apr 8, 2018

Lassulus commented Apr 9, 2018

dotlambda commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 9, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

dotlambda commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

dotlambda commented Apr 11, 2018

Lassulus commented Apr 12, 2018

dotlambda commented Apr 12, 2018

Lassulus commented Apr 1, 2018 •

edited